Username mapping for both of kubespawner's escaping schemes #168
+44
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In panels related to storage, we try to map directory names to the usernames that they were created for. We want to support mapping `[email protected]` as a username to either `my-2ename-40example-2ecom` or `my-name-example-com---abcd1234`, and previously we only mapped `my-2ename-40example-2ecom`, but with this change we could map also `my-name-example-com---abcd1234` to the username. ``` actual username: [email protected] legacy scheme ("escape"): my-2ename-40example-2ecom modern scheme ("safe"): my-name-example-com---abcd1234 ``` This requires version >=1.2.0 of jupyterhub-groups-exporter where the `username_safe` label is available, but won't error without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on 2i2c-org/jupyterhub-groups-exporter#41 and has also been tested together with it.
In panels related to storage, we try to map directory names to the usernames that they were created for.
We want to support mapping
[email protected]as a username to eithermy-2ename-40example-2ecomormy-name-example-com---abcd1234, and previously we only mappedmy-2ename-40example-2ecom, but with thischange we could map also
my-name-example-com---abcd1234to the username.This requires version >= 1.2.0 of jupyterhub-groups-exporter, where the
username_safelabel is available, but it won't error without it.