Provide username_safe label for kubespawners modern escaping #41
+241
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapping an NFS server directory name like
my-2ename-40example-2ecomto the username[email protected]can be done using the jupyterhub-groups-exporter provided labels currently, specifically theusername_escapedlabel. But KubeSpawner now has two escaping schemes, "escape" and "safe". "safe" is the new default, while "escape" has been used for a long time, so it is useful to be able to map escaped usernames from either scheme.With this PR, we ensure that we can map directory names to usernames, regardless of whether the directory names were created from escaped usernames under the old or new escaping scheme. This has been verified in jupyterhub/grafana-dashboards#168.