Switch to GitHub actions on CI #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @fcollonval @ianhi since this was discussed in #86. Example run in the fork: https://github.com/jtpio/widget-ts-cookiecutter/runs/2011603959 For now this PR skips tests and docs, just so we can have a basic workflow working for other PRs. But we should eventually add them back, and also check the generated workflow from the cookiecutter is also correct. |
ianhi
approved these changes
Mar 2, 2021
| # Make sure our lab extension was installed. | ||
| jupyter labextension list 2>&1 | grep -ie "jupyter-widget-testwidgets.*OK" | ||
| # Make sure our lab extension can be linked. | ||
| jupyter labextension link |
There was a problem hiding this comment.
On the PR for jlab3 we can update this to check if jupyter labextension develop . --overwrite works.
There was a problem hiding this comment.
yes absolutely we can do that in #90
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting the GitHub Actions part of #86, so it can be used for other PRs such as #90.