Skip to content

Add js test and docs back to CI #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianhi opened this issue Mar 2, 2021 · 1 comment · Fixed by #86
Closed

Add js test and docs back to CI #92

ianhi opened this issue Mar 2, 2021 · 1 comment · Fixed by #86

Comments

@ianhi
Copy link
Contributor

ianhi commented Mar 2, 2021

For now this PR skips tests and docs, just so we can have a basic workflow working for other PRs. But we should eventually add them back, and also check the generated workflow from the cookiecutter is also correct.

Originally posted by @jtpio in #91 (comment)

@jtpio
Copy link
Member

jtpio commented Mar 2, 2021

Thanks @ianhi.

For the tests, which might be fixed by #86:

# TODO: re-enable tests
# pytest
# npm run test:ci

For the docs:

# - name: Check docs can be build + links
# run: |
# pushd jupyter-widget-testwidgets/docs
# make html
# make linkcheck
# popd

And for the generated cookiecutter workflow:

- name: Test the extension
run: |
python -m pip install --upgrade -v -e ".[test, examples, docs]"
npm run lint:check
pytest
npm run test:ci
- name: Check docs can be build + links
run: |
pushd docs
make html
make linkcheck
popd
python -m pytest_check_links --links-ext=.md -o testpaths=. -o addopts=

@ianhi ianhi linked a pull request Mar 11, 2021 that will close this issue
@jtpio jtpio closed this as completed in #86 Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants