Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native ag grid cell editors support #4263

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Native ag grid cell editors support #4263

merged 5 commits into from
Dec 13, 2024

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Oct 8, 2024 •
edited
Loading

Based on top of #4257 & #4276, to be looked at after #4276 work is verified

Use Site example "Cell Editor", or storybook "Provided Cell Editor" story to test, ag grid doc: https://www.ag-grid.com/javascript-data-grid/provided-cell-editors/

  • Fix editable-cell input inline padding
  • Fix long text cell overflow
  • Large text popout panel background color missing
  • Large text popout text area focus ring
  • Large text popout text area rounded corner styling options
  • (rich) select editor padding
  • (rich) select editor focus ring
  • (rich) select editor chevron icon (ag grid uses triangle, swapped with chevron. We can't do up&down given we don't have up chevron in ag grid icon font set)
  • rich select editor corner radius
  • editable-cell input/select text vertical alignment (off by 1 when editing? only happening in lower zoom?) likely this can't be fixed
  • new site doc example
  • date floating filter input border, remove?
  • ....

#4144

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8d35ee2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/ag-grid-theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:45pm

@origami-z origami-z force-pushed the 4144-ag-break-parts branch from e9efcef to a6f0a70 Compare October 8, 2024 13:37
@origami-z origami-z force-pushed the 4144-ag-built-in-editors branch from 85cf269 to a6232f2 Compare October 8, 2024 13:44
@origami-z origami-z force-pushed the 4144-ag-break-parts branch 3 times, most recently from 0c8466a to 4637cf6 Compare October 17, 2024 08:54
@origami-z origami-z force-pushed the 4144-ag-built-in-editors branch from e311949 to 468b076 Compare October 18, 2024 08:36
@origami-z origami-z changed the base branch from 4144-ag-break-parts to 4275-ag-grid-v32 October 18, 2024 08:37
@origami-z origami-z changed the title [WIP] Custom ag grid cell editors [WIP] Native ag grid cell editors Oct 23, 2024
@origami-z origami-z force-pushed the 4275-ag-grid-v32 branch 2 times, most recently from e3f8849 to 3d79612 Compare November 13, 2024 09:07
@origami-z origami-z force-pushed the 4144-ag-built-in-editors branch from 68f8d36 to cd5bdee Compare November 13, 2024 09:13
@origami-z origami-z changed the title [WIP] Native ag grid cell editors Native ag grid cell editors support Nov 13, 2024
@origami-z origami-z marked this pull request as ready for review November 13, 2024 09:13
@origami-z origami-z force-pushed the 4144-ag-built-in-editors branch from cd5bdee to 46908f4 Compare November 13, 2024 09:26
@origami-z origami-z force-pushed the 4275-ag-grid-v32 branch 2 times, most recently from 2c75efe to 3c60c63 Compare November 18, 2024 09:31
Base automatically changed from 4275-ag-grid-v32 to main November 19, 2024 13:34
@origami-z origami-z force-pushed the 4144-ag-built-in-editors branch from 46908f4 to 3775137 Compare December 10, 2024 11:09
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 10, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 10, 2024
@origami-z origami-z force-pushed the 4144-ag-built-in-editors branch from bf8c337 to 8e1bdf5 Compare December 11, 2024 12:22
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 11, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 11, 2024
@origami-z
Ag grid built in cell editor support
442e8ea 
- Fix editable-cell input padding
- Fix long text cell overflow
- Add agLargeTextCellEditor support
- Add theme support for agSelectCellEditor
- Add agRichSelectCellEditor support
- Add site doc example
- Enable enterprise feature on site
@origami-z
Design review feedbacks
c902d2b
@origami-z
Add 4144
5bf1ff8
@origami-z
Fix snapshot test
a2c6d60
@origami-z
Design review r2
8d35ee2
@origami-z origami-z force-pushed the 4144-ag-built-in-editors branch from 1c6be2f to 8d35ee2 Compare December 12, 2024 16:39
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 13, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Dec 13, 2024
@origami-z origami-z merged commit 2719afb into main Dec 13, 2024
15 checks passed
@origami-z origami-z deleted the 4144-ag-built-in-editors branch December 13, 2024 09:52
@origami-z origami-z mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhoppers2008 bhoppers2008 bhoppers2008 approved these changes

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@origami-z @joshwooding @bhoppers2008