ag grid theme built-in editors support

[origami-z]

Salt ag grid theme now only contain editable-cell which targets basic text editor. Teams has asked what's best approach for other type of editors.

• Can we theme more native ag grid editors? e.g. Should Rich select editor be overridden with chevron icon instead of triangle?
• What's the best way to support custom Salt form components (Dropdown, Combobox)? e.g. how to deal with additional padding in .ag-cell, how to pick correct board?

Some prototype maybe useful: https://stackblitz.com/edit/salt-ag-grid-theme-v2-mgojro?file=index.js,App.jsx,package.json,style.css

[mark-tate]

Galao Goal: kickoff to help us define the requirements

[mark-tate]

Galao Goal: update theme to work with AG Grid theme to work with custom editor

[origami-z]

Oct 7 - starting today with some stories

[mark-tate]

Latte Goal: release Salt theme support for built-in Editor

[origami-z]

Oct 17: Half way, will continue after #4275

[origami-z]

Oct 21 : Ben to review previews in PR

[dplsek]

moving into Lungo pending @bhoppers2008 review

[mark-tate]

Lungo : @bhoppers2008 blocked, requires review

[joshwooding]

Moved to Macchiato sprint. No capacity in Lungo

[mark-tate]

Macc Goal: Review by EOS (secondary priority to filter icon, which will unblock Fusion)

[bhoppers2008]

Ben to set up time to review with Zhihao/ do on Wed/Thurs.

[mark-tate]

red eye goal: @bhoppers2008 to review but @origami-z has only half a sprint

any changes pushed to backlog for prioritisation in Q1

[origami-z]

Met with Ben

• Cell editor doc example move under checkbox selection
• Move checkbox column to not first column, to avoid confusion with ag row selection
• Wording / guidance update
  • Prefer built-in, then custom editors
  • Rich select – more capability, requires enterprise
• Styling
  • Check large text editor - textarea’s text / size/color/weight
  • Text area overlay, remove spacing-100, remove border, pad out
  • Default select: Right Chevron spacing
  • Select & rich select
    • Selected item top/bottom border
    • Dropdown list border -> blue (refer to dropdown)
    • Dropdown list shadow, check whether can match
• TODO
  • Check HD Compact
  • Add Backlog: ag grid Custom editor examples doc to Q2

[mark-tate]

Red Eye goal: now reviewed, PR to update by end of wk 1 (before zh leaves)
Figma updates to follow in Feb (@bhoppers2008 to create)

[origami-z]

Dec 12 - reviewed by Ben, pending code review and merge

[origami-z]

Merged #4263, ready to be released