Group Mullvad Nodes by Country, Scrollable Nodes Section, Exit node subtitle#18
Group Mullvad Nodes by Country, Scrollable Nodes Section, Exit node subtitle#18rjocoleman wants to merge 4 commits into
Conversation
|
Hi @rjocoleman, Thanks for you contribution!! I have a few points I'd like you take a look at:
You addition to show the exitnode as subtitle I already merged to master a5ce530 I also created a PR(#19) to fix this scroll issue, it's more simple as it simply forces the scrollbar to show in the submenu, so if the items above are hard to achieve we can use as fallback. |
|
@joaophi I've addessed some of these issues with a new PR on #20 I think its slightly more idiomatic gnome-shell than this PR. The height of the box is now set dynamically. Keyboard support is problematic. I ended up totally reinventing scrolling a couple of ways and it seems very fragile, so I removed the code. In #20 there is some interaction between scrolling when the mouse is over an open sub menu. I didn't track down that issue yet either. I have also updated this PR with many of features, but I don't think the approach here is as good as #20, but there are some trade-offs for both. |
247dc9b to
f5ecc37
Compare

More changes in a single commit than I'd like, sorry!
This PR:
ScrollablePopupMenuclass that supports scrolling and sections with titles.PopupMenu.PopupMenuSectionto it.