Improve mullvad exit node selection and add quick action button to disable exit node#36
Open
abn wants to merge 3 commits into
Open
Improve mullvad exit node selection and add quick action button to disable exit node#36abn wants to merge 3 commits into
abn wants to merge 3 commits into
Conversation
This change replaces the previously non-functional drop down menu listing Mullvad exit nodes with a dedicated UI with filtering for exit node selection. This change also allows users to select "best node" automatically based on the lowest priority value, similar to Tailscale mobile apps.
Introduce a `DisableExitNodeButton` to toggle the deactivation of an active Tailscale exit node. The button updates dynamically based on the exit node state and integrates seamlessly into the action bar of the menu header.
Author
|
@joaophi happy to make any changes required to get this ready for merge. Thank you for the extension. |
|
Just tested this, works beautifully! |
|
I have been using this fork for the past few days, and it works perfectly. Have had no problems with the Mullvad integration. |
Author
|
@joaophi would be great to get this released in a new version of the extension. Anything I could do to help? |
Author
|
A version of this fix with #45 is available at https://github.com/abn/tailscale-gnome-qs/tree/mullvad-gnome-49 for those that need it. Hopefully the compatibility fix and these changes can get merged & released. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change contains the following changes.
Also closes #18 #20.
Mullvad Exit Node Selection
Users can select a node by selecting a city - this will select the best node, ie. lowest priority integer value, similar to how the Tailscale mobile apps alow; or they can choose to expand the entry to see available nodes for that city and select a specific one.
New Option Outside Nodes Menu
Default Dialog View
Filtered Dialog View
Expanded Location View
Exit Node Quick Action
The button is only reactive when an exit node is active.