Fix local endpoint count (prevent premature shutdown). #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1906 +/- ##
============================================
- Coverage 40.97% 40.96% -0.01%
Complexity 1707 1707
============================================
Files 336 336
Lines 17421 17427 +6
Branches 2321 2322 +1
============================================
+ Hits 7138 7139 +1
- Misses 9591 9595 +4
- Partials 692 693 +1
Continue to review full report at Codecov.
|
JonathanLennox
approved these changes
Jun 3, 2022
bgrozev
added a commit
that referenced
this pull request
Jun 7, 2022
* fix: Do not call endpointExpired() for RelayedEndpoints. * ref: Rename endpointExpired to localEndpointExpired. * fix: Log, do not shutdown if endpoint count is invalid. * ref: Rename localEndpointExpired to endpointExpired. * fix: Call Relay.endpointExpired for Relayed endpoints.
damencho
pushed a commit
that referenced
this pull request
Jul 11, 2022
* fix: Do not call endpointExpired() for RelayedEndpoints. * ref: Rename endpointExpired to localEndpointExpired. * fix: Log, do not shutdown if endpoint count is invalid. * ref: Rename localEndpointExpired to endpointExpired. * fix: Call Relay.endpointExpired for Relayed endpoints.
This was referenced Jul 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.