Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Silence detection #1926

Merged
merged 1 commit into from
Aug 9, 2022
Merged

feat: Silence detection #1926

merged 1 commit into from
Aug 9, 2022

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Jul 25, 2022

No description provided.

/**
* The special endpoint ID to use for silence (when there is no dominant speaker).
*/
private static final String SILENCE = "SILENCE";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to use an ID that syntactically cannot be used in colibri? (Is there one?)

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1926 (e270225) into master (42bc1b9) will increase coverage by 0.01%.
The diff coverage is 55.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1926      +/-   ##
============================================
+ Coverage     41.09%   41.10%   +0.01%     
+ Complexity     1709     1708       -1     
============================================
  Files           337      337              
  Lines         17415    17437      +22     
  Branches       2314     2318       +4     
============================================
+ Hits           7156     7167      +11     
- Misses         9568     9576       +8     
- Partials        691      694       +3     
Impacted Files Coverage Δ
...rc/main/java/org/jitsi/videobridge/Conference.java 29.77% <25.00%> (ø)
.../jitsi/videobridge/message/BridgeChannelMessage.kt 62.89% <40.00%> (+0.07%) ⬆️
...rg/jitsi/videobridge/ConferenceSpeechActivity.java 63.04% <53.57%> (-4.16%) ⬇️
...itsi/videobridge/ConferenceSpeechActivityConfig.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42bc1b9...e270225. Read the comment docs.

@bgrozev bgrozev merged commit c096124 into jitsi:master Aug 9, 2022
@bgrozev bgrozev deleted the silence branch May 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants