-
Notifications
You must be signed in to change notification settings - Fork 57
Add blank line rule in port_map #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add blank line rule in port_map #1450
Conversation
The test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as I can tell. I think the commits have to be squashed before this can be merged.
Could you also implement this rule as generic_map_201
?
Good point, I can add the generic thing as you mention! |
Signed-off-by: Rui Chen <[email protected]>
Afternoon @lgu-appear and @benthie , I reviewed the two rules and made a slight change to take comments into account. If there are no comments, then the rule behaves the same as your original rule. If there are comments then the rule stops removing blank lines up to the comment. I am ready to merge this to master, but wanted to your feedback on my changes. Thanks for the PR. --Jeremy |
Hey! Thanks for reviewing. Can there be the possibility to include or not the blank line above the comments? In my case, I do not want any blank line, even above comments. Loan |
Description
Add a rule for detecting blank lines in the port map of an instantiation of a module.
Screenshots
See
tests\port_map\rule_201_test_input.vhd
andtests\port_map\rule_201_test_input.fixed.vhd
.