more fonts #331
Merged
more fonts #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I don't know how to explain it. But I'm also seeing the 0,0 stats here. The progress slider on the preview also seems broken. Let me know if you can't reproduce. Otherwise, looks good. |
Collaborator
Author
|
@jeffeb3 I was able to reproduce your bug and fixed the stats issue. This should fix it in i18n, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Source Han Serif (a Chinese-capable font) and implements on-demand font loading to avoid loading all fonts at startup, which isn't scalable. Fonts now load on demand when selected in the UI.
Also added:
To test Source Han Serif, you can cut/paste: 你好世界 = Hello World, 沙盘艺术 = Sand Table Art