Complete Internationalization of Sandify #325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The added font is SourceHanSerif, which is an open source font and you can use it with confidence. |
Author
|
screenshot： |
Collaborator
|
Thanks for your work on this. It looks great. I've created a new PR which keeps your translations with some minor modifications to the approach. Please take a look and give me your feedback when you can. |
Collaborator
|
As a follow-up, I wanted to note that #331 has the SourceHanSerif fonts included. |
Owner
|
Thank you for this. I'm closing it in favor of #330. And sorry for the long delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thank you for creating such a wonderful tool—I really enjoy using it!
I’ve spent some time fully internationalizing Sandify and have added Chinese translations. The implementation has undergone basic testing to ensure functionality.
It would be great if you could review and merge this PR. Thank you for your consideration!