Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(renovate): rework config #1911

Closed
wants to merge 0 commits into from
Closed

chore(renovate): rework config #1911

wants to merge 0 commits into from

Conversation

kim-tsao
Copy link
Member

Fixes: https://issues.redhat.com/browse/RHIDP-2699

  • Re-enabled Renovate to create PRs
  • Limit PR creation. Grouping are now based on the following:
    • Test/devdependencies are managed by RHDH for all plugins
    • Additional package rules are used to group monorepo related PRs (material-ui, react, babel, storybook, linters). These will be managed by RHDH
    • Dependencies are expected to be managed by the respective plugin owner teams
    • All major bumps require dashboard approval
  • Removed the Notifications rule since those plugins now live upstream

*Note: Major rules are specified in order to organize the dashboard view. It's not expected that teams will make batch updates to a set of unrelated packages at the same time so it's just informational. For example, compare the test repo dashboard to the backstage-plugins dashboard

@kim-tsao kim-tsao requested a review from a team as a code owner July 18, 2024 19:41
@openshift-ci openshift-ci bot requested review from 04kash and dzemanov July 18, 2024 19:41
@kim-tsao
Copy link
Member Author

/retest

schultzp2020
schultzp2020 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@karthikjeeyar
Copy link
Contributor

/retest

2 similar comments
@kim-tsao
Copy link
Member Author

/retest

@kim-tsao
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot removed the lgtm label Jul 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 21, 2024

New changes are detected. LGTM label has been removed.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kim-tsao kim-tsao closed this Jul 23, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: schultzp2020

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schultzp2020 schultzp2020 schultzp2020 approved these changes

@04kash 04kash Awaiting requested review from 04kash

@dzemanov dzemanov Awaiting requested review from dzemanov

Assignees

@schultzp2020 schultzp2020

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-tsao @karthikjeeyar @schultzp2020