Skip to content

Commit

Permalink
chore(tests): let playright kill a process if it's already dead (#1925)
Browse files Browse the repository at this point in the history
chore(tests) let playright kill a process that doesn't exist anymore; if it's already been killed, don't fail when trying to re-kill it

Signed-off-by: Nick Boldt <[email protected]>
  • Loading branch information
nickboldt committed Jul 23, 2024
1 parent 4eb2035 commit 54ad02c
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/pr-playwright.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,15 @@ jobs:
# Kill the plugin
pid=$(lsof -i :3000 -Fp | grep p | sed s/p//)
kill -9 $pid && echo "$f shut down"
kill -9 $pid || true
echo "$f shut down"
cd $root/plugins
done
# Kill backend
pid=$(lsof -i :7007 -Fp | grep p | sed s/p//)
kill -9 $pid && echo "Backend shut down"
kill -9 $pid || true
echo "Backend shut down"
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4
if: always()
with:
Expand Down

0 comments on commit 54ad02c

Please sign in to comment.