Skip to content

fix: prevent save status indicator from persisting on note switch #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j4rviscmd merged 2 commits into from
Mar 28, 2026
Merged

fix: prevent save status indicator from persisting on note switch #102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53a5a64
fix: prevent save status indicator from persisting on note switch
j4rviscmd Mar 28, 2026
13b5443
merge: resolve conflict with origin/main
j4rviscmd Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/shared/ui/SaveStatusIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ const SAVED_DISPLAY_MS = 3000
* - `saved` – check icon only (fades out after 3 s)
* - `error` – warning icon + "Save failed"
* - `idle` – hidden
*
* @param props - Component props.
* @param props.status - The current save state to render.
*/
export function SaveStatusIndicator({
status,
Expand All @@ -29,24 +32,28 @@ export function SaveStatusIndicator({
undefined
)

// Synchronise the local display state with the upstream save status.
// Any previous auto-hide timer is cleared first to prevent stale callbacks.
useEffect(() => {
clearTimeout(savedTimerRef.current)

// "idle" means no save activity – hide the indicator immediately.
if (status === 'idle') {
if (!savedTimerRef.current) {
setDisplay(null)
}
setDisplay(null)
return
}

setDisplay(status)

// After showing the "saved" check icon, start a timer to fade it out.
if (status === 'saved') {
savedTimerRef.current = setTimeout(() => {
savedTimerRef.current = undefined
setDisplay(null)
}, SAVED_DISPLAY_MS)
}

return () => clearTimeout(savedTimerRef.current)
}, [status])

if (locked) {
Expand All @@ -70,10 +77,10 @@ export function SaveStatusIndicator({
)}
{display === 'saved' && <Check className="h-3.5 w-3.5 text-success" />}
{display === 'error' && (
<>
<AlertCircle className="h-3.5 w-3.5 text-destructive" />
<span className="text-destructive">Save failed</span>
</>
<span className="inline-flex items-center gap-1 text-destructive">
<AlertCircle className="h-3.5 w-3.5" />
Save failed
</span>
)}
</span>
)
Expand Down
Loading