fix: prevent save status indicator from persisting on note switch#102
Merged
fix: prevent save status indicator from persisting on note switch#102
Conversation
Remove isTimerActiveRef guard that caused a deadlock when status transitioned from 'saved' to 'idle' during note navigation — the timer was cleared but the ref was never reset, leaving the checkmark visible indefinitely. Add cleanup function to clear timer on unmount. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isTimerActiveRefguard that caused a deadlock when save status transitioned from'saved'to'idle'during note navigationclearTimeoutbut the ref was never reset, leaving the checkmark icon visible indefinitelyRoot Cause
In
SaveStatusIndicator.tsx, whenstatuschanged from'saved'→'idle'(note switch):clearTimeout()killed the 3-second timerisTimerActiveRef.currentremainedtrue(never reset since timer callback never fires)setDisplay(null)was guarded by!isTimerActiveRef.current, creating a deadlockFix
isTimerActiveRefentirelydisplaytonullwhenstatus === 'idle'useEffectcleanup function to clear timer on unmountTest plan
🤖 Generated with Claude Code