Skip to content

fix(sentry): Filter 404s from error capture #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(sentry): Filter 404s from error capture #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/nurse_scheduling/server/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ async def starlette_http_error_handler(request: Request, exc: StarletteHTTPExcep
"""Capture client HTTP errors and normalize multipart size failures."""
if request.url.path == "/optimize" and _is_form_parser_size_error(exc):
exc = StarletteHTTPException(status_code=413, detail="Scheduling YAML is too large")
if 400 <= exc.status_code < 500:
if 400 <= exc.status_code < 500 and exc.status_code != 404:
capture_invalid_request(request, exc.status_code, exc.detail)
return await http_exception_handler(request, exc)

Expand Down
Loading