fix(sentry): Filter 404s from error capture - #50
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the
starlette_http_error_handlerincore/nurse_scheduling/server/app.pyto explicitly exclude 404 Not Found errors from being captured by Sentry.Previously, all 4xx HTTP exceptions were captured, leading to Sentry being spammed with "Invalid API request" issues triggered by external bot traffic scanning for non-existent paths. These 404s are noise and not indicative of actual application errors.
The change adds
and exc.status_code != 404to the condition that triggers Sentry capture, ensuring that only relevant 4xx client errors (e.g., 400, 401, 403, 413, 422) are reported.Fixes NURSE-SCHEDULING-59