Fixes ray initialization to correctly direct subprocess output #3533
+10
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running Ray directly from tuner.py, Ray is not correctly initialized within
invoke_tuning_run()
. The two problems associated with this are discussed in #3532. To solve them, this PR:ray_init()
fromutil.get_gpu_node_resources()
. Now, ray needs to be initialized before callingutil.get_gpu_node_resources()
. This change actually reverses Fixes the missing Ray initialization #3350, which was merged to add the missing initialization when usingtuner.py
, but it is safer to explicitly initialize Ray with the correct arguments outside of theutil.get_gpu_node_resources()
.invoke_tuning_run()
to be beforeutil.get_gpu_node_resources()
so we explicitly initialize it before and do not raise an exception later.ray_init()
if Ray was already initialized.Fixes #3532
Type of change
Screenshots
Change 1:

Change 2:

Change 3:

Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there