Fixes rl_games
workflow's log_root_path
to be the absolute path
#3531
+4
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to previous changes, the
rl_games
workflow'slog_root_path
is no longer the absolute path if the pbt option is not used, causing further issues. This PR fixes this by making it an absolute path again.Fixes #3530
Type of change
Screenshots
Before:
IsaacLab/scripts/reinforcement_learning/rl_games/train.py
Lines 129 to 135 in 3a0db9d
After:
Note
While this fixes the path to be absolute when pbt is not used, I am not sure if
log_root_path = os.path.join(agent_cfg["pbt"]["directory"], log_root_path)
is correct or absolute, as I do not use pbt. Should it not be something like the following?
log_root_path = os.path.abspath(os.path.join(log_root_path, agent_cfg["pbt"]["directory"]))
I would appreciate any feedback on this.
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there