fix(ios): remove percent-encoding of cookie values in CapacitorCookies #8249
+1
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwolz
commented
Nov 19, 2025
Comment on lines
-53
to
-55
| public func decode(_ value: String) -> String { | ||
| return value.removingPercentEncoding! | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This seems to not have been in use at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the percent-encoding of cookie values in CapacitorCookies plugin implementation on iOS and therefore make it behave the same as on Android.
Fixes: #8248
Working example can be found here (build locally with non published packages): https://github.com/michaelwolz/capacitor-cookies/tree/working-version
Screenshot