Skip to content

fix(ios): remove percent-encoding of cookie values in CapacitorCookies #8249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −9
Open

fix(ios): remove percent-encoding of cookie values in CapacitorCookies #8249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ios/Capacitor/Capacitor/Plugins/CapacitorCookieManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,6 @@ public class CapacitorCookieManager {
return url
}

public func encode(_ value: String) -> String {
return value.addingPercentEncoding(withAllowedCharacters: .urlPathAllowed)!
}

public func decode(_ value: String) -> String {
return value.removingPercentEncoding!
}
Comment on lines -53 to -55
Copy link
Contributor Author

@michaelwolz michaelwolz Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to not have been in use at all.


public func setCookie(_ domain: String, _ action: String) {
let url = getServerUrl(domain)!
let jar = HTTPCookieStorage.shared
Expand Down
2 changes: 1 addition & 1 deletion ios/Capacitor/Capacitor/Plugins/CapacitorCookies.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class CAPCookiesPlugin: CAPPlugin, CAPBridgedPlugin {

let expires = call.getString("expires", "")
let path = call.getString("path", "")
cookieManager!.setCookie(url, key, cookieManager!.encode(value), expires, path)
cookieManager!.setCookie(url, key, value, expires, path)
call.resolve()
}

Expand Down
Loading