Skip to content

fix width/height when value is lower than 1 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OS-ruimoreiramendes merged 2 commits into from
Mar 23, 2026
Merged

fix width/height when value is lower than 1 #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0a823a
fix width/height when value is lower than 1
OS-ruimoreiramendes Mar 23, 2026
df9dbe9
remove null assertions
OS-ruimoreiramendes Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions android/src/main/java/com/capacitorjs/plugins/camera/IonCameraFlow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class IonCameraFlow(
editInApp = call.getBoolean("editInApp") ?: true,
quality = call.getInt("quality") ?: DEFAULT_QUALITY,
width = call.getInt("targetWidth") ?: 0,
height = call.getInt("targetWidth") ?: 0,
height = call.getInt("targetHeight") ?: 0,
correctOrientation = call.getBoolean("correctOrientation") ?: DEFAULT_CORRECT_ORIENTATION
)
}
Expand All @@ -218,15 +218,19 @@ class IonCameraFlow(

fun getCameraSettings(call: PluginCall): IonCameraSettings {
val settings = IonCameraSettings()
settings.quality = call.getInt("quality", IonCameraSettings.DEFAULT_QUALITY)!!
settings.targetWidth = call.getInt("targetWidth", 0)!!
settings.targetHeight = call.getInt("targetHeight", 0)!!
settings.correctOrientation = call.getBoolean("correctOrientation", IonCameraSettings.DEFAULT_CORRECT_ORIENTATION)!!
settings.encodingType = call.getInt("encodingType", IonCameraSettings.DEFAULT_ENCODING_TYPE)!!
settings.saveToGallery = call.getBoolean("saveToGallery", IonCameraSettings.DEFAULT_SAVE_IMAGE_TO_GALLERY)!!
settings.allowEdit = call.getBoolean("allowEdit", false)!!
settings.editInApp = call.getBoolean("editInApp", true)!!
settings.includeMetadata = call.getBoolean("includeMetadata", false)!!
settings.quality = call.getInt("quality") ?: IonCameraSettings.DEFAULT_QUALITY

val width = call.getInt("targetWidth") ?: 0
val height = call.getInt("targetHeight") ?: 0

settings.targetWidth = if (width < 1) -1 else width
settings.targetHeight = if (height < 1) -1 else height
settings.correctOrientation = call.getBoolean("correctOrientation") ?: IonCameraSettings.DEFAULT_CORRECT_ORIENTATION
settings.encodingType = call.getInt("encodingType") ?: IonCameraSettings.DEFAULT_ENCODING_TYPE
settings.saveToGallery = call.getBoolean("saveToGallery") ?: IonCameraSettings.DEFAULT_SAVE_IMAGE_TO_GALLERY
settings.allowEdit = call.getBoolean("allowEdit") ?: false
settings.editInApp = call.getBoolean("editInApp") ?: true
settings.includeMetadata = call.getBoolean("includeMetadata") ?: false
settings.shouldResize = settings.targetWidth > 0 || settings.targetHeight > 0
return settings
}
Expand Down
Loading