fix width/height when value is lower than 1 - #14
Merged
OS-ruimoreiramendes merged 2 commits intoMar 23, 2026
Merged
Conversation
OS-ruimoreiramendes
requested review from
OS-pedrogustavobilro and
alexgerardojacinto
March 23, 2026 16:20
alexgerardojacinto
approved these changes
Mar 23, 2026
OS-pedrogustavobilro
approved these changes
Mar 23, 2026
Comment on lines
+223
to
+224
| val width = call.getInt("targetWidth", 0)!! | ||
| val height = call.getInt("targetHeight", 0)!! |
Contributor
There was a problem hiding this comment.
I think in general we could / should avoid null assertions, but this doesn't need to happen in this PR.
Contributor
Author
There was a problem hiding this comment.
I can fix it in this PR, for all the variables, not only this two
Contributor
There was a problem hiding this comment.
If you want to, that's fine in my book :D
Contributor
Author
There was a problem hiding this comment.
I prefer to fix it rigth now, otherwise this will never get fixed xD
OS-pedrogustavobilro
approved these changes
Mar 23, 2026
OS-ruimoreiramendes
merged commit Mar 23, 2026
f18cfc8
into
feat/RMET-4099/camera-unification
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.