Skip to content

Fix(prime import offt) #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix(prime import offt) #1961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78a9585
ddi: fix wrong sizeof when zeroing DecodeStatusReportData
akshatsinha0 Sep 21, 2025
1e41a29
bufmgr: use off_t for lseek result in PRIME import toavoid 64-bit Tru…
akshatsinha0 Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion media_driver/linux/common/codec/ddi/media_libva_decoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ VAStatus DdiDecode_StatusReport(PDDI_MEDIA_CONTEXT mediaCtx, DecodePipelineAdapt
for (uint32_t i = 0; i < uNumCompletedReport; i++)
{
decode::DecodeStatusReportData tempNewReport;
MOS_ZeroMemory(&tempNewReport, sizeof(CodechalDecodeStatusReport));
MOS_ZeroMemory(&tempNewReport, sizeof(tempNewReport));
MOS_STATUS eStatus = decoder->GetStatusReport(&tempNewReport, 1);
DDI_CHK_CONDITION(MOS_STATUS_SUCCESS != eStatus, "Get status report fail", VA_STATUS_ERROR_OPERATION_FAILED);

Expand Down
2 changes: 1 addition & 1 deletion media_softlet/linux/common/codec/ddi/dec/ddi_decode_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,7 @@ VAStatus DdiDecodeFunctions::StatusReport(
for (uint32_t i = 0; i < uNumCompletedReport; i++)
{
DecodeStatusReportData tempNewReport;
MOS_ZeroMemory(&tempNewReport, sizeof(CodechalDecodeStatusReport));
MOS_ZeroMemory(&tempNewReport, sizeof(tempNewReport));
MOS_STATUS eStatus = decoder->GetStatusReport(&tempNewReport, 1);
DDI_CODEC_CHK_CONDITION(MOS_STATUS_SUCCESS != eStatus, "Get status report fail", VA_STATUS_ERROR_OPERATION_FAILED);

Expand Down
8 changes: 4 additions & 4 deletions media_softlet/linux/common/os/i915/mos_bufmgr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3501,11 +3501,11 @@ mos_gem_bo_create_from_prime(struct mos_bufmgr *bufmgr, struct mos_drm_bo_alloc_
* later, we can lseek on the prime fd to get the size. Older
* kernels will just fail, in which case we fall back to the
* provided (estimated or guess size). */
ret = lseek(prime_fd, 0, SEEK_END);
if (ret != -1)
bo_gem->bo.size = ret;
off_t sz =lseek(prime_fd,0,SEEK_END);
if(sz>= 0)
bo_gem->bo.size=(unsigned long)sz;
else
bo_gem->bo.size = size;
bo_gem->bo.size = (unsigned long)size;

bo_gem->bo.handle = handle;
bo_gem->bo.bufmgr = bufmgr;
Expand Down
8 changes: 3 additions & 5 deletions media_softlet/linux/common/os/i915_production/mos_bufmgr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3493,19 +3493,17 @@ mos_gem_bo_create_from_prime(struct mos_bufmgr *bufmgr, struct mos_drm_bo_alloc_
* later, we can lseek on the prime fd to get the size. Older
* kernels will just fail, in which case we fall back to the
* provided (estimated or guess size). */
ret = lseek(prime_fd, 0, SEEK_END);
if (ret != -1)
bo_gem->bo.size = ret;
off_t sz=lseek(prime_fd,0, SEEK_END);
if(sz>=0) bo_gem->bo.size=(unsigned long)sz;
else
bo_gem->bo.size = size;
bo_gem->bo.size=(unsigned long)size;

bo_gem->bo.handle = handle;
bo_gem->bo.bufmgr = bufmgr;

bo_gem->gem_handle = handle;

atomic_set(&bo_gem->refcount, 1);

bo_gem->name = alloc_prime->name;
bo_gem->validate_index = -1;
bo_gem->reloc_tree_fences = 0;
Expand Down