Fix(prime import offt) #1961
Open
Fix(prime import offt) #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| atomic_set(&bo_gem->refcount, 1); | ||
|
|
||
| atomic_set(&bo_gem->refcount, 1);// |
| DecodeStatusReportData tempNewReport; | ||
| MOS_ZeroMemory(&tempNewReport, sizeof(CodechalDecodeStatusReport)); | ||
| MOS_ZeroMemory(&tempNewReport, sizeof(tempNewReport)); | ||
| //MOS_ZeroMemory(&tempNewReport, sizeof(CodechalDecodeStatusReport)); |
There was a problem hiding this comment.
You mean delete it from commented?
|
thanks @akshatsinha0 , it LGTM, but about the commits, looks the third one is just to remove the sentence which was commented in previous changes. so , maybe we should squash them? |
Yah, obvious is to squash the last one with the first two, or what do you say, squash all 3 into 1? |
akshatsinha0
force-pushed
the
fix(prime-import-offt)
branch
from
3640463 to
1e41a29
Compare
|
see, I split it into two fixup! commits and autosquashed them(with functional ones),& regularly pushed the branch. so Is it ok now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use off_t for lseek() result and cast to bo size