[UR] Make invalid kernel arguments UB #17962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kbenzie
reviewed
Apr 11, 2025
Instead of returning INVALID_KERNEL_ARGS, calling a kernel with invalid arguments is now UB. In addition, the Invalid kernel arguments enum itself is now deprecated (as it is no longer returned) and the OpenCL backend now writes a message to the log.
RossBrunton
force-pushed
the
ross/newnewnewargval
branch
from
987b245 to
dfefafd
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning INVALID_KERNEL_ARGS, calling a kernel with invalid
arguments is now UB. In addition, the Invalid kernel arguments enum
itself is now deprecated (as it is no longer returned) and the OpenCL
backend now writes a message to the log.