[UR] Add UR_DEVICE_INFO_VALIDATES_ON_LAUNCH #17953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/newnewargval
branch
from
6e8d61c to
c30c8fc
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
This device info is used to specify whether a given device can validate arguments passed to a kernel when it is launched. This also updates the spec to specify that if this value is not set, then running a kernel with invalid arguments is UB. This does not imply any behavior changes in adapters themselves; they already UB-ed anyway. This just writes it into the spec and makes some conformance tests not fail them for it.
RossBrunton
force-pushed
the
ross/newnewargval
branch
from
c30c8fc to
3d263a7
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
More internal discussion and it looks like a device info property is probably overkill and we should just make it always UB (and have OpenCL report an error to some log somewhere). |
Does it mean that this PR still needs to be reviewed, or can it be closed converted to a draft? |
|
Replaced by this. Sorry about all the pings! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This device info is used to specify whether a given device can validate
arguments passed to a kernel when it is launched. This also updates the
spec to specify that if this value is not set, then running a kernel
with invalid arguments is UB.
This does not imply any behavior changes in adapters themselves; they
already UB-ed anyway. This just writes it into the spec and makes
some conformance tests not fail them for it.