[NFC] clang-format nativecpu_utils.cpp. #17570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had turned off clang-formatting for nativecpu_utils.cpp because the macro definitions we used confused the formatter to the point of making the result unreadable, but by changing the macros so that they are followed by a semicolon, and by avoiding NCPUPREFIX and spelling out the concatenation directly, we can get it into a state where it does work for clang-format.
coldav
approved these changes
Mar 21, 2025
|
@intel/llvm-gatekeepers This is ready to be merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had turned off clang-formatting for nativecpu_utils.cpp because the macro definitions we used confused the formatter to the point of making the result unreadable, but by changing the macros so that they are followed by a semicolon, and by avoiding NCPUPREFIX and spelling out the concatenation directly, we can get it into a state where it does work for clang-format.