[SYCL] Change SPIR-V Enum token type from unsigned int to int for groups builtins #17445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ups builtins Motivation is the same as PR intel#17438, i.e. unifying SPIR-V builtin mangling to enhance SYCL AOT support for backend targets that bypass SPIR-V generation.
steffenlarsen
requested changes
Mar 13, 2025
Naghasan
reviewed
Mar 13, 2025
Naghasan
approved these changes
Mar 14, 2025
hvdijk
reviewed
Mar 17, 2025
|
kindly ping @intel/dpcpp-cfe-reviewers for review |
Fznamznon
reviewed
Mar 18, 2025
| def : SPVBuiltin<name, [Event, UInt, PointerType<AGenTypeN, GlobalAS>, PointerType<ConstType<AGenTypeN>, LocalAS>, Size, Size, Event], Attr.Convergent>; | ||
| // TODO: Allow enum flags instead of Int ? | ||
| // TODO: We should enforce that the Int must be a literal. | ||
| def : SPVBuiltin<name, |
There was a problem hiding this comment.
Same as in #17438 (comment) , should we have a test checking that clang emits correct signature and mangling for the builtin in the IR?
There was a problem hiding this comment.
thanks @Fznamznon
done in bc42ed1
hvdijk
approved these changes
Mar 18, 2025
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
wenju-he
commented
Mar 19, 2025
|
Heads up that there will be a trivially resolved conflict between this and #17570. I can wait a little bit for your PR to go in first, and then update mine, or I can get mine in first and then you can update, whichever you prefer so long as we don't both end up waiting on the other one to merge first. :) |
|
Thanks @hvdijk, either way is fine for me. :) @intel/llvm-gatekeepers please merge, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation is the same as PR #17438, i.e. unifying SPIR-V builtin mangling to enhance SYCL AOT support for backend targets that bypass SPIR-V generation.