Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code/app): Fix bug in test app and example app where proposal parts were not always processed in order of sequence number #851

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

romac
Copy link
Member

@romac romac commented Feb 13, 2025

Closes: #XXX


PR author checklist

For all contributors

For external contributors

…ts were not processed in order of sequence number
@romac romac removed the request for review from greg-szabo February 13, 2025 12:44
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.35%. Comparing base (0968a34) to head (a4458ea).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #851   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files         186      186           
  Lines       15951    15953    +2     
=======================================
+ Hits        13136    13138    +2     
  Misses       2815     2815           
Flag Coverage Δ
integration 82.19% <ø> (+<0.01%) ⬆️
mbt 8.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core ∅ <ø> (∅)
engine ∅ <ø> (∅)
app ∅ <ø> (∅)
starknet ∅ <ø> (∅)

@romac romac merged commit 8e7f30b into main Feb 14, 2025
22 checks passed
@romac romac deleted the romac/fix-stream-map branch February 14, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant