fix(code/app): Fix bug in test app and example app where proposal par…

…ts were not processed in order of sequence number (#851)
informalsystems · Feb 14, 2025 · 8e7f30b · 8e7f30b
1 parent 0449465
commit 8e7f30b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/code/crates/test/app/src/streaming.rs b/code/crates/test/app/src/streaming.rs
@@ -46,10 +46,13 @@ impl<T> MinHeap<T> {
     }
 
     fn drain(&mut self) -> Vec<T> {
-        self.0
-            .drain()
-            .filter_map(|msg| msg.0.content.into_data())
-            .collect()
+        let mut vec = Vec::with_capacity(self.0.len());
+        while let Some(MinSeq(msg)) = self.0.pop() {
+            if let Some(data) = msg.content.into_data() {
+                vec.push(data);
+            }
+        }
+        vec
     }
 }
 

diff --git a/code/examples/channel/src/streaming.rs b/code/examples/channel/src/streaming.rs
@@ -46,10 +46,13 @@ impl<T> MinHeap<T> {
     }
 
     fn drain(&mut self) -> Vec<T> {
-        self.0
-            .drain()
-            .filter_map(|msg| msg.0.content.into_data())
-            .collect()
+        let mut vec = Vec::with_capacity(self.0.len());
+        while let Some(MinSeq(msg)) = self.0.pop() {
+            if let Some(data) = msg.content.into_data() {
+                vec.push(data);
+            }
+        }
+        vec
     }
 }