Repository navigation
Conversation
This was referenced Sep 28, 2026
Coverage
|
indent
Bot
force-pushed
the
fix/lsp-hover
branch
from
October 14, 2026 19:08
916da7b to
2385923
Compare
indent
Bot
force-pushed
the
fix/lsp-diagnostics
branch
2 times, most recently
from
October 14, 2026 19:32
0d04d90 to
bc62863
Compare
indent
Bot
force-pushed
the
fix/lsp-hover
branch
from
October 14, 2026 19:32
2385923 to
616645a
Compare
indent
Bot
force-pushed
the
fix/lsp-diagnostics
branch
from
October 14, 2026 19:54
bc62863 to
f6b8b37
Compare
indent
Bot
force-pushed
the
fix/lsp-hover
branch
from
October 14, 2026 19:54
616645a to
2d484e2
Compare
run_lsp_watch sent a buffer-only initial snapshot and delivered the engine's retained diagnostics only as a later Reset, so one-shot `yas lsp diagnostics` always printed nothing and exited 0. The initial snapshot of a diagnostics subscription now waits for the engine's first diagnostics replay. --wait now waits for indexing, then for the next published diagnostics, ending after 5 seconds without any server update so a clean workspace still returns. Help: lsp --root is relative to the client's cwd, not the server's; learn.md names the actual `Busy: Warming` error.
indent
Bot
force-pushed
the
fix/lsp-diagnostics
branch
from
October 15, 2026 01:43
f6b8b37 to
974ee7b
Compare
indent
Bot
force-pushed
the
fix/lsp-hover
branch
from
October 15, 2026 01:43
2d484e2 to
bd7d77b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #27; the diff shows only this change.
yas lsp diagnosticswithout--watchprinted nothing and exited 0, even when errors existed. The initial snapshot fromrun_lsp_watchheld only buffers, and the engine's retained diagnostics arrived later as a Reset.--waitdidn't help: it waited only for READY, which comes before rust-analyzer publishes its check results.Fix
--waitnow keeps watching diagnostics and backend state after READY. It prints on the first publish that changes the diagnostic set, or after 5 seconds with no server update, so a clean workspace still returns. (An empty set can't be told apart from no publish on the wire, hence the 5-second fallback.)--roothelp (9 flags) now says the path is relative to the client's cwd.learn.mdnow uses the realBusy: Warmingerror.Testing
Checked by hand with rust-analyzer:
diaganddiag --waitshow the E0308 error and exit 1.--waitreturns 0 in about 0.7 s.Tag
@indentto continue the conversation here.