Repository navigation
Conversation
This was referenced Sep 28, 2026
Coverage
|
indent
Bot
force-pushed
the
fix/lsp-diagnostics
branch
from
October 14, 2026 19:08
94eb579 to
0d04d90
Compare
indent
Bot
force-pushed
the
fix/fs-grep
branch
2 times, most recently
from
October 14, 2026 19:32
0bbfcac to
dcce491
Compare
indent
Bot
force-pushed
the
fix/lsp-diagnostics
branch
2 times, most recently
from
October 14, 2026 19:54
bc62863 to
f6b8b37
Compare
indent
Bot
force-pushed
the
fix/fs-grep
branch
from
October 14, 2026 19:54
dcce491 to
660cc7d
Compare
enumerate_paths walked with hidden(false), which keeps dotfiles as the design wants but also descended into .git, so grep and find searched repository metadata. .git is now pruned like an ignored directory, and with ignored paths included it is walked and marked ignored (docs/design/fs-grep.md). GREP's default per-file cap was the page record limit and counted from the first match, so a file with more matches than one page could hold lost the rest even though the cursor resumed inside it. Zero now caps nothing. `yas fs grep -m N` sent N as the page record limit and kept paging, so it never limited anything, -m 1 failed with Invalid, and small pages hit the dropped-match bug above. It now uses the default page size and stops after N matching files; a file split across pages counts and prints once, and multi-page searches no longer warn that results were truncated.
indent
Bot
force-pushed
the
fix/lsp-diagnostics
branch
from
October 15, 2026 01:43
f6b8b37 to
974ee7b
Compare
indent
Bot
force-pushed
the
fix/fs-grep
branch
from
October 15, 2026 01:43
660cc7d to
0e5ad19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #28. The diff shows only this change.
What was wrong
enumerate_pathswalked withhidden(false). That correctly keeps dotfiles, but it also descended into.git, which contradictsdocs/design/fs-grep.md.-m Nas the page record limit and kept paging, so-mnever limited anything.-m 1failed with Invalid, and small pages hit the dropped-match bug.Fix
.git: pruned by default. With--no-ignoreit is walked and marked ignored.max_per_file = 0now means no cap.Testing
grep_default_per_file_cap_keeps_every_match_across_pagesandgrep_and_search_prune_git_metadata_unless_ignored_paths_are_included.yas-server --lib yas_fspasses (13 tests).-m 1returns 1 file and-m 2returns 2.fs find HEADdoesn't find.git/HEAD.Tag
@indentto continue the conversation here.