Repository navigation
Conversation
yas open always serves the local server's UI, which lists configured remotes; a command-line target was silently dropped. Credentials in the echoed --on value are masked.
Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #21; the diff shows only this change.
yas openaccepted--onand--hubbut ignored both. It always opens the local server's UI, and that UI already lists the configured remotes.The flags are now refused with a clear error instead of silently ignored:
yas open --on Xexits 2 and suggestsyas remote add NAME X. If X is ashare:URI, the passphrase in the message is masked.--hubon the command line is refused.YAS_HUBin the environment is still accepted.The
openlong help now says that both flags are refused.New test:
open_refuses_targets_it_would_ignore.Tag
@indentto continue the conversation here.