Repository navigation
Conversation
The server dropped DISCONNECT's reason and sent GOAWAY with empty detail, so a kicked CLI printed 'YAS server is closing with Ok: no detail'. The reason now travels in GOAWAY detail as the new optional Core extension GOAWAY_REASON_EXTENSION (1), and the CLI prints 'disconnected by the YAS server: REASON'.
Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #22; the diff shows only this change.
The Clients panel says the kick reason is shown to the client, but the server dropped DISCONNECT's reason. It sent GOAWAY with empty detail, so a kicked CLI printed only
yas: YAS server is closing with Ok: no detail.Fix
GOAWAY_REASON_EXTENSION(1). This is a schema addition, regenerated withcargo xtask protocol, and the compatibility check passes.yas: disconnected by the YAS server: REASON.docs/design/yas.mdandlearn.mdare updated.Testing
goaway_reason_round_trips_as_optional_detail(yas-wire) andgoaway_with_a_disconnect_reason_names_it(CLI).yas events tailclient kicked withyas client disconnect ID --reason "Removed by an administrator"printed the reason.Tag
@indentto continue the conversation here.