Skip to content

Label help overlay keys by what they do - #21

Open
mgasner wants to merge 1 commit into
fix/audio-disable-bitratefrom
fix/help-overlay-labels
Open

mgasner wants to merge 1 commit into
fix/audio-disable-bitratefrom
fix/help-overlay-labels

Conversation

@mgasner

@mgasner mgasner commented Sep 28, 2026 •

Copy link
Copy Markdown

Stacked on #20; the diff shows only this change.

Two labels in the help overlay didn't match what their keys do:

  • Ctrl+B r was labelled "Preview, Debug, Web pane", but it only toggles the preview panel. It is now labelled "Preview panel".
  • Tab / Shift+Tab was labelled "Prev / Next window", while the prefix map calls it "Next pane". It is now labelled "Prev / Next pane".

The strings the old labels used (help.panels, help.prevNextWindow) are no longer referenced, so they are removed from i18n.ts.

In js/ui, tsc --noEmit is clean and vitest passes 1033 tests.

View in Indent
Tag @indent to continue the conversation here.

Ctrl+B r only toggles the preview panel, and Tab/Shift+Tab cycle panes, as
the prefix map already says. Drop the two unused strings.
@github-actions

Copy link
Copy Markdown

Coverage

Crate Lines Functions Regions
alacritty-driver 85.6% (1081/1263) 89.4% (84/94) 89.3% (1746/1955)
browser 25.5% (309/1212) 30.4% (34/112) 27.7% (605/2183)
cli 34.9% (8332/23890) 35.8% (772/2155) 35.6% (12060/33910)
composite-transport 96.3% (526/546) 98.4% (60/61) 96.2% (884/919)
compositor 54.9% (11394/20760) 66.0% (831/1260) 54.7% (15778/28840)
desktop 78.4% (4460/5691) 71.6% (393/549) 75.1% (6211/8267)
edge 62.9% (798/1268) 50.9% (82/161) 57.7% (1038/1799)
fonts 77.3% (1257/1626) 82.7% (129/156) 78.9% (2424/3071)
fssync 85.3% (1597/1872) 84.4% (179/212) 86.4% (2812/3255)
git 70.4% (4462/6334) 68.5% (337/492) 67.3% (6313/9386)
guest 67.3% (6829/10148) 67.0% (488/728) 66.6% (8935/13416)
lsp 78.7% (3573/4542) 80.8% (336/416) 76.7% (5408/7054)
proxy 57.8% (1120/1937) 50.5% (104/206) 59.0% (1749/2965)
runtime-dir 93.6% (117/125) 100.0% (14/14) 94.8% (218/230)
sd-notify 73.9% (68/92) 100.0% (6/6) 83.2% (109/131)
server 68.7% (79717/116080) 70.4% (5712/8110) 66.3% (105508/159153)
ssh 42.6% (270/634) 51.5% (34/66) 42.9% (428/998)
terminal-model 49.9% (314/629) 62.3% (38/61) 50.3% (505/1004)
uplink 94.0% (581/618) 92.6% (50/54) 93.0% (1061/1141)
webrtc-forwarder 33.8% (1337/3961) 42.0% (136/324) 36.2% (2318/6409)
webserver 77.0% (1421/1846) 75.2% (179/238) 80.0% (2453/3067)
website 35.1% (355/1012) 34.4% (53/154) 35.8% (607/1694)
xtask 0.0% (0/5131) 0.0% (0/131) 0.0% (0/9124)
yas 87.8% (26446/30135) 93.2% (2030/2179) 82.7% (41655/50374)
Total 64.8% (156364/241352) 67.3% (12081/17939) 63.0% (220825/350345)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant