Repository navigation
Conversation
- YAS_AUDIO=0 only kept PipeWire from starting when media input and portals were also off. With either on, the runtime started and desktop audio was still offered and streamed. The output device is now unavailable and OPEN_OUTPUT is refused under YAS_AUDIO=0 regardless of why PipeWire runs. - A viewer at "Desktop default" (0 kbps) reset the encoder to a built-in 64 kbps, overriding YAS_AUDIO_BITRATE. The configured bitrate is now what a server-default viewer, the last unsubscribe, and a pipeline restart use. - When audio cannot start and was not disabled, print one line naming the reason at normal verbosity; -v keeps the detailed lines.
Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #19; the diff shows only this change.
What was wrong
YAS_AUDIO=0: it only stopped PipeWire when media input and portals were also off. If either was on, desktop audio was still offered and streamed to viewers.YAS_AUDIO_BITRATE: a viewer left at "Desktop default" sends 0 kbps, which the spec defines as "server default". The server treated that as a built-in 64 kbps and reset the encoder to it, overriding the configured value.-v.Fix
YAS_AUDIO=0: the output device is reported unavailable and OPEN_OUTPUT is refused, whatever PipeWire is running for.YAS_AUDIO_BITRATE: server-default viewers, the last unsubscribe, and pipeline restarts all use the configured bitrate. An explicit viewer bitrate still wins, taking the highest across viewers.[audio] desktop audio unavailable: missing on $PATH: pipewire, …; -v for details, YAS_AUDIO=0 to silenceTesting
viewers_at_the_server_default_get_the_configured_bitrateandunavailable_reason_names_the_first_missing_dependency.audio::testsand media tests pass.YAS_AUDIO=0silences it.Tag
@indentto continue the conversation here.