Repository navigation
Conversation
- capture --scale now resizes the surface with the RESIZE scale extension before capturing instead of being rejected. - capture --quality is removed: Surface CAPTURE has no quality input. - record --codec h264-444/av1-444 announce 4:4:4 through the view color capabilities extension instead of being rejected. - record help names the real default files (.h264, or .obu for AV1). - surface scroll accepts a negative amount, as learn.md shows.
Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #18; the diff shows only this change.
Changes
capture --scale: implemented. It used to be rejected. It now sends a RESIZE carrying the RESIZE scale extension, which the server supports, and then captures. The resize uses the surface's current logical size, or--width/--heightif given, at N/120. The default of 0 leaves the scale alone.capture --quality: removed. Surface CAPTURE has no quality input.record --codec h264-444/av1-444: implemented. These used to be rejected. They now announce 4:4:4 through the view color-capabilities extension, the same way the browser does. The server still falls back to 4:2:0 unless itsYAS_CHROMAsetting and the encoder allow 4:4:4.recorddefault file: the help now names the real default:surface-ID.h264, orsurface-ID.obufor AV1.surface scroll: negative amounts are accepted (allow_negative_numbers). For example,yas surface scroll 1 -2 --horizontalscrolls left two notches, where 0.3.0 gave a clap error.Testing
record_codecs_announce_444_through_color_capabilitiescapture_scale_rides_the_resize_scale_extensionsurface_scroll_accepts_a_negative_amountTag
@indentto continue the conversation here.