Skip to content

Fix for imagej/imagej-legacy#239 #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix for imagej/imagej-legacy#239 #313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44fd436
Fix for imagej/imagej-legacy#239
tferr Feb 19, 2025
97edb92
Update MacroPreprocessor.java
tferr Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/java/net/imagej/legacy/plugin/MacroPreprocessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,18 @@ public void process(final Module module) {
if (!ij1Helper.isMacro()) return;
for (final ModuleItem<?> input : module.getInfo().inputs()) {
final String name = input.getName();
final Class<?> type = input.getType();
if (Button.class.equals(type) || ColorTable.class.equals(type) || ItemVisibility.MESSAGE.equals(input.getVisibility())) {
// resolve buttons, display messages, and color tables. For the latter a parameter
// value is provided but IJM cannot do anything with it. See #239 for details
module.resolveInput(name);
continue;
}
final String value = ij1Helper.getMacroParameter(name);
if (value == null) {
// no macro parameter value provided
continue;
}
final Class<?> type = input.getType();
if (!convertService.supports(value, type)) {
// cannot convert macro value into the input's actual type
continue;
Expand Down