Fix for imagej/imagej-legacy#239 #313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends imagej#262 further: - Ignore Buttons (these are not recordable in ij.gui.GenericDialog, so this change _should_ not carry breaking changes) - Ignore ColorTables (these are assigned a value parameter but IJM does not know what to do with it) - Ignore inputs tagged w/ ItemVisibility.MESSAGE (as per documentation: this indicated that the item's value is intended as a message to the user rather than an actual parameter to the module execution)
|
@ctrueden: Just to tag you directly in case you are no longer monitoring #239. TLDR; After a quick test this seems to solve macro recording. Tests also run successfully after this. The PR basically merges what had already been proposed by @imagejan and @NicoKiaru in the PTBIOP update site ;) |
|
Here is a compiled jar (inside a zip) if some one wants to try: |
tferr
added a commit
to morphonets/SNT
that referenced
this pull request
Feb 20, 2025
This depends on imagej/imagej-legacy#313
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-latest-java-21-bundles-ready-for-community-testing/112417/12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #262 further: