Skip to content

docs(openspec): skill ownership, maintenance and handover contract - #1060

Open
martindissingmadsen wants to merge 2 commits into
iflytek:mainfrom
martindissingmadsen:feat/skill-owner-transfer
Open

martindissingmadsen wants to merge 2 commits into
iflytek:mainfrom
martindissingmadsen:feat/skill-owner-transfer

Conversation

@martindissingmadsen

@martindissingmadsen martindissingmadsen commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Updates the OpenSpec change clarify-skill-ownership-transfer with the ownership, maintenance and handover contract discussed in this PR. Documentation only; no code.

  • A Skill is user-owned or namespace-owned. A namespace-owned Skill has at most one maintainer.
  • Exact-record addressing for same-slug Skills across Web, API and CLI.
  • Handover requests: voluntary and recovery, recipient acceptance, 14-day expiry, invalidation, notifications and audit.
  • Member departure: loss of internal access, conversion on new removals, explicit remediation of historical records.

Open questions with proposed defaults are at the end of proposal.md.

Delivery plan

  1. TEAM access-rule fix
  2. Ownership model, exact addressing and the handover workflow
  3. Conversion on member removal and historical remediation

Each delivery will be a separate PR from main, after the contract is agreed.

Validation

  • Every new requirement has at least one scenario (checked by script).
  • The OpenSpec CLI validator was not run.
  • The existing Chinese text is unchanged; new sections are added above it.

🤖 Generated with Claude Code

@martindissingmadsen
martindissingmadsen force-pushed the feat/skill-owner-transfer branch 2 times, most recently from 642682c to 4851584 Compare November 3, 2026 12:40
@XiaoSeS

XiaoSeS commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the contribution. We agree that skill ownership transfer is useful for offboarding and changes in maintenance responsibilities. Before proceeding, we would like to refine the product rules: allowing a namespace OWNER to immediately transfer any member’s skill is broader than intended.

Proposed workflow

Scenario Who can initiate When ownership changes
Voluntary transfer The current skill owner, while their account is active and they remain a namespace member After the recipient accepts
Recovery takeover The namespace OWNER, only when the current skill owner has left the namespace or their account is disabled; a reason is required After the recipient accepts
Recovery takeover by the namespace OWNER themselves The same recovery conditions apply After one explicit confirmation with a reason
Platform emergency takeover SUPER_ADMIN through a separate emergency action Requires a reason, a clear impact warning, and an audit record; not the routine handover path

Namespace ADMINs should not gain takeover permission. While the current skill owner remains an active member, the namespace OWNER should not be able to transfer their skill unilaterally. Shared maintenance is a separate capability.

Request lifecycle and UX

  • The recipient must be an active, non-system member of the same namespace. Support member search or pagination rather than limiting selection to the first 100 members.
  • Before submission, show both owners, any linked global copy, and the resulting permission changes.
  • Recipients should be able to accept or reject through an in-app notification and a skill management entry. Email may be an optional reminder, but must not be required to complete the workflow.
  • Ownership remains unchanged while acceptance is pending. Requests should support cancellation and expiration.
  • At acceptance, revalidate the current owner, recipient eligibility, namespace state, naming conflicts, and recovery conditions. A pending recovery request should become invalid if the original owner rejoins and their account is active again.
  • Notify the relevant users when the transfer completes and retain an audit trail. System-owned and GitHub-sync-managed skills should remain excluded initially.

Consistency and review findings

Our source review identified the following issues. These have not yet been reproduced with concurrent transactions against a real database:

  1. Transfer concurrent with initial global promotion approval: approval can read the old owner, then create a global copy with that owner after the source has been transferred. This breaks source/copy ownership consistency.
  2. Eligibility checks concurrent with revocation: the recipient can be removed from the namespace after eligibility is checked but before the transfer commits.
  3. Truncated member selection: the dialog only loads the first 100 members, making other eligible recipients unavailable.

Please coordinate locking and revalidation across ownership transfer, promotion approval, and relevant membership/state changes, and add real database concurrency tests. Acceptance must also prevent duplicate execution and stale requests from overwriting a newer ownership change.

Preserve the skill ID, address, versions, statistics, historical author attribution, and existing review records. Transfer the source and its active global copy atomically. Authorization must reflect the new owner after commit without relying on asynchronous search reindexing.

For the initial scope, please exclude bulk transfers, cross-namespace moves, multiple maintainers, and Token-based ownership transfer. Could you first update the workflow, permission matrix, and request-state design, then revise this PR against the agreed contract?


感谢提交。我们认可技能所有权交接的价值,但当前“空间 OWNER 可以立即转移任意成员技能”的范围偏宽,建议先明确以下产品规则。

建议流程

场景 发起条件 生效方式
主动转让 当前技能所有者,账号正常且仍是空间成员 接收人确认后生效
异常接管 原所有者已退出空间或账号停用,由空间 OWNER 发起并填写原因 接收人确认后生效
负责人接管给自己 满足相同异常接管条件 填写原因并明确确认后生效,无需重复确认
平台应急接管 SUPER_ADMIN,通过独立应急入口 必填原因、明确影响提示并记录审计,不作为日常交接方式

普通空间 ADMIN 不新增接管权限。原所有者仍是正常成员时,空间 OWNER 不能单方面转移其技能;共同维护应作为另一项能力处理。

申请与交互

  • 接收人为同空间正常启用的非系统账号,支持成员搜索或分页,不限于前 100 人。
  • 提交前展示双方、关联全局副本及权限变化。
  • 接收人通过站内通知和技能管理入口接受或拒绝;邮件提醒可选,不作为流程依赖。
  • 待确认期间所有者不变,申请支持取消、到期。
  • 确认时重新检查所有者、接收资格、空间状态、同名冲突和接管条件。原所有者重新加入且账号正常时,未完成的异常接管申请应失效。
  • 完成后通知相关人员并保留审计。首期继续排除系统技能和 GitHub 同步托管技能。

一致性与审查问题

源码 Review 发现以下问题,尚未通过真实数据库并发事务复现:

  1. 首次全局提升审批与交接并发时,可能产生属于旧所有者的全局副本,导致源与副本归属不一致。
  2. 接收资格检查后、交接提交前,目标成员可能已被移出空间。
  3. 选择器只加载前 100 名成员,后续合法接收人无法选择。

请协调交接、提升审批及相关成员/状态变更的锁定和复查机制,并补真实数据库并发测试;同时防止重复确认和过期申请覆盖新的所有权变更。

保留技能 ID、地址、版本、统计、历史作者署名和已有审核记录。源技能与活动全局副本应原子交接;提交后接口按新所有者授权,不能依赖异步搜索重建撤销旧权限。

首期不扩展批量交接、跨空间移动、多人 Maintainer 或 Token 交接权限。建议先更新流程、权限矩阵及申请状态设计,确认后再调整当前 PR。

@martindissingmadsen

Copy link
Copy Markdown
Contributor Author

Thanks for the review. We agree with all points. Below is the revised design. Once agreed, I'll rework the PR and record the contract in openspec/changes/clarify-skill-ownership-transfer.

1. Who can transfer

Kind Started by Condition Takes effect
VOLUNTARY Current owner Owner is active and a namespace member Recipient accepts
RECOVERY Namespace OWNER Owner has left the namespace or is disabled. Reason required Recipient accepts
RECOVERY_SELF Namespace OWNER, to themselves Same as RECOVERY. Reason required On confirmation
EMERGENCY SUPER_ADMIN, separate admin action Reason required, impact warning shown On confirmation

For all kinds:

  • Recipient: active, non-system member of the same namespace.
  • Namespace must be active.
  • System-owned and GitHub-sync skills are excluded.
  • The global copy moves with its source. It can't be transferred alone.
  • Browser session only. Tokens are rejected.
  • Namespace ADMINs get no new rights.
  • The previous owner keeps their authorship but loses owner-only access (Q12).

2. Requests

New table skill_owner_transfer_request:
id, skill_id, namespace_id, kind, from_owner_id, to_user_id, initiated_by, reason, status, expires_at, decided_by, decided_at, decision_note, version, created_at, updated_at

PENDING ─┬─ accept (recipient) ─────────────────► ACCEPTED
         ├─ reject (recipient) ─────────────────► REJECTED
         ├─ cancel (initiator or namespace OWNER) ► CANCELLED
         ├─ expiry (default 14 days) ───────────► EXPIRED
         └─ condition no longer holds ──────────► INVALIDATED
  • One pending request per skill (partial unique index).
  • from_owner_id must still match the skill's owner at acceptance. A stale request can't overwrite a newer change.
  • State changes are conditional updates on status and version. A second accept, or an accept racing a cancel, gets 409.
  • RECOVERY_SELF and EMERGENCY are stored directly as ACCEPTED, so every ownership change has a request row.
  • If the original owner rejoins or is re-enabled, their pending RECOVERY requests are invalidated.

3. Acceptance

Lock order, following the existing user-then-namespace order:

  1. Both user rows, ordered by id
  2. Namespace
  3. Request
  4. Source skill, then its global copy

Under these locks, check again: request state and expiry, current owner, the kind's condition, recipient eligibility, namespace status, slug conflicts, and pending reviews (section 4). Then update both skills, the request and the audit log in one transaction. Notifications and search reindex run after commit.

Your three findings:

  1. Promotion approval: approvePromotion will lock the source skill before reading its owner. The copy then always gets the right owner.
  2. Member removal / account disabling: these already lock the user row first, so they can't interleave with acceptance.
  3. 100-member limit: replaced by a paginated server-side search.

Permissions read owner_id from the database, so they change at commit. A test will confirm this with the reindex disabled.

4. Pending reviews

A transfer can't be accepted while the skill or its copy has a pending version review, promotion, visibility change or avatar review. Reviewers decide first. Reason: some approvals check that the submitter still owns the skill (e.g. approvePromotion).

Unchanged: skill ID, address, versions, statistics, authorship, review history, labels and suite memberships.

5. Notifications and UI

  • New in-app notification category OWNERSHIP. Email is optional.
  • Notified: the recipient on request; the initiator on every outcome; the previous owner (if active) on completion.
  • Skill page: "Transfer ownership" for the owner; "Take over" for the namespace OWNER when recovery applies; a banner while a request is pending.
  • Dialog: recipient search, summary of both owners, global copy and permission changes, reason.
  • My Skills: new "Ownership requests" tab to accept, reject or cancel.

6. API (session only)

POST /api/web/skills/{namespace}/{slug}/owner-transfers
GET  /api/web/me/owner-transfers?direction=incoming|outgoing&status=
POST /api/web/owner-transfers/{id}/accept | reject | cancel
GET  /api/web/namespaces/{slug}/owner-transfer-candidates?q=&page=
POST /api/admin/skills/{id}/owner-takeover

7. Audit

SKILL_OWNER_TRANSFER_REQUESTED, _REJECTED, _CANCELLED, _EXPIRED, _INVALIDATED; SKILL_OWNER_CHANGED per moved skill; SKILL_OWNER_EMERGENCY_TAKEOVER.

8. Tests

Real-database concurrency tests (Testcontainers PostgreSQL), each pair run in both orders:

  1. Accept vs. promotion approval: source and copy keep the same owner.
  2. Accept vs. removing or disabling the recipient.
  3. Accept vs. accept, and accept vs. cancel: one wins.
  4. Recovery accept vs. original owner rejoining: request invalidated.
  5. Stale request after another transfer: rejected.

Plus unit, controller and E2E tests.

Out of scope

Bulk transfers, cross-namespace moves, multiple maintainers, token-based transfers.

Questions

  1. EMERGENCY in this PR or a follow-up?
  2. Block acceptance on pending reviews (our proposal), or let them carry over?
  3. Is 14 days a good default for expiry?

@XiaoSeS

XiaoSeS commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the revised design and for offering to continue. We have clarified the same-slug case and would like to propose a small extension to the ownership model, rather than requiring renaming or introducing multi-maintainer collaboration. This comment consolidates and updates our earlier direction; please assess the scope before starting a rewrite.

1. Product outcome

A recipient may already own an unpublished PRIVATE Skill with the same namespace and slug as the incoming Skill, including when the incoming Skill is PUBLIC or NAMESPACE_ONLY.

For this case, the incoming Skill becomes namespace-owned, and the recipient becomes its maintainer after acceptance. Their existing PRIVATE Skill remains user-owned and unchanged. Do not rename, overwrite, delete or automatically merge either Skill. Keep IDs, content, versions, attribution, statistics and visibility intact.

Our proposed consistent default is to use that same namespace-owned + maintainer result for non-conflicting handovers too. Once namespace-owned, later handovers change the maintainer, not ownership back to a user; rejoining the namespace does not automatically reclaim a Skill. Please include this default explicitly in the revised contract for confirmation before implementation.

Namespace ownership does not grant every member write or private-read access. Namespace OWNER/ADMIN can govern namespace-owned Skills; an accepted, active-member maintainer can maintain/delete them subject to existing lifecycle and dependency checks. Do not expand namespace ADMIN powers to unilaterally transfer an active member's user-owned Skill.

2. Minimal implementation proposal

Prefer extending the existing model, repositories, authorization helpers, notification system and audit trail. No synthetic namespace user, generic polymorphic-principal framework, multi-maintainer table, new settings system or full page redesign is needed.

One candidate representation in skill is:

  • an ownership discriminator, defaulting existing rows to user ownership;
  • the existing owner_id for user-owned rows, nullable for namespace-owned rows;
  • one nullable maintainer user reference for namespace-owned rows;
  • the existing namespace reference, with linked global derivatives handled consistently with their source.

These are suggested semantics, not mandated field names or DDL. Keep original authorship in existing contribution records; do not reinterpret the old owner as the historical author.

Preserve the user-owned (namespace, slug, user) uniqueness rule. Namespace-owned same-slug records may remain separate, so exact-record addressing is a prerequisite: selection, handover, reads/downloads, updates and deletion must target the intended Skill and recheck authorization. Existing slug resolution must not silently select the first match. Preserve unambiguous legacy behavior and define a clear ambiguous-target response plus an explicit selection path for Web/API/CLI updates. Do not loosen existing publication/install-coordinate conflict rules. This prerequisite must be complete before enabling conflicting handovers.

3. Handover workflow

Keep your request lifecycle, one pending request per Skill, server-side recipient search and in-app notification/management entry. Email remains optional. Browser sessions only for handover management; Tokens gain no transfer permission.

  • Voluntary handover: an active current owner/maintainer initiates; the eligible recipient accepts.
  • Recovery: namespace OWNER initiates when the responsible user is no longer eligible; require a reason and recipient acceptance. Self-recovery uses an explicit confirmation with a reason.
  • Defer platform EMERGENCY takeover, cross-namespace moves and bulk transfer.
  • Default expiry: 14 days; enforce it at action time and release expired pending slots.
  • At completion, revalidate membership/account state, current ownership/maintainer, request state, namespace state and linked-copy consistency. A grant or Token capability belonging to the former user does not transfer to the recipient.

For voluntary/recovery completion, retain the conservative pending-review restriction for now and show the blocking item. In the OpenSpec, explicitly distinguish scans, version reviews, avatar/visibility reviews and promotions; settle scan-only behavior before coding. Recheck these conditions under the actual mutation locks, including creation of new pending work. This is different from member removal below, which must not wait for reviews to finish.

4. Member removal and historical data: linked work, not an implicit expansion of this PR

Agreed behavior for new TEAM member removals is immediate withdrawal of internal access/maintenance rights and conversion of that user's user-owned Skills in the affected namespace to namespace ownership. Clear any maintainer assignment to the removed user; do not automatically assign a replacement. PRIVATE remains PRIVATE. Account deactivation alone does not change ownership.

Scans continue; accepted reviews remain but must revalidate current conditions, without automatic approval or elevated worker authority. Stale personal handover requests are invalidated. Removal cannot be blocked by unfinished handover/review work. Handle source/global-copy and grant revocation consistently and audit the result.

For historical rows, do not bulk reassign ownership just because the user is currently absent from membership. Keep the old ownership metadata and preserve data; use a separately authorized, audited remediation flow for ownership conversion. Current-member authorization must still govern access to internal files and previews, including historical records. Public versions remain accessible under normal public rules; independent administrator authority is evaluated separately. Data retention and access revocation are separate concerns.

This access-rule change and historical-remediation UI should be linked work packages; you are not automatically expected to deliver all of them in this PR.

5. Delivery and validation

Suggested split:

  1. Ownership representation, exact-record addressing and compatibility prerequisite.
  2. This PR's handover workflow and minimal UI, notifications and audit.
  3. Separately scoped member-removal/access-rule integration and historical remediation.

Existing rows keep user ownership on schema upgrade. Upgrade every backend/consumer to understand namespace-owned rows before enabling conversion; old binaries may assume non-null owner_id, so direct rollback after conversion is not assumed safe.

Acceptance should cover same-slug PRIVATE + shared-Skill handover, exact update/download/delete targeting, absent/non-accepting recipients, duplicate accept vs cancel/removal, promotion/source-copy races, private-content authorization, expiry, populated-database upgrade and legacy-client behavior. Record passed, failed and untested cases separately. Reuse existing audit records for ownership/maintainer before-and-after values, real operator, reason and request; system actions must not be attributed to the departed user.

Would you be comfortable implementing the ownership/addressing prerequisite and handover workflow, or would you prefer a narrower part? We can share the adjacent work. Please update the existing OpenSpec and identify remaining contract questions first; keep the current PR as the discussion/delivery reference. This is a design proposal and scope invitation, not approval of the existing implementation.


中文说明:

谢谢你愿意继续开发。我们希望用最小的“个人所属/空间所属+单一维护负责人”扩展,解决交接冲突,不引入多人维护或整站改版。

  • 接收人已有同 slug 的 PRIVATE 技能时,被交接技能转为空间所属,接收人接受后负责维护;原 PRIVATE 技能不变,不改名、不覆盖、不自动合并。建议无冲突交接也采用同一结果,实施前在正式契约中确认。
  • 核心表建议只补归属类型、空间所属技能的负责人,并调整用户所有者的可空语义;复用已有空间、权限、通知与审计,不创建假空间用户。具体字段与迁移方案由正式设计确认。
  • 同名记录必须精确定位,后续上传、读取、下载、删除不能“取第一条”;无歧义旧请求兼容,有歧义时提供明确选择路径。原有发布坐标约束不放宽。
  • 保留申请、接受/拒绝/取消/失效和默认14天到期;单独校核各类扫描/审核及全局副本,不能靠旧检查结果完成交接。平台应急接管后续单独做。
  • 新成员移除的空间承接、访问撤销,以及历史遗留治理作为关联工作明确拆分。历史记录不在升级时批量转归属;但保留历史数据不等于保留退出后的内部访问权。
  • 现有数据默认保留个人归属;全部后端理解新模型后再启用转化,不能承诺产生新归属数据后直接回滚旧程序。

这比原PR扩大了范围,因此先邀请你评估愿意承接“归属/定位前置+交接主体”还是其中一部分,其他工作可以分担。请先更新现有OpenSpec并列出待确认项,不必另开替代PR,也不要求你直接按整套讨论开始大改。本评论是方案与范围邀请,不代表当前代码已验收。

@XiaoSeS

XiaoSeS commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Overall approach: TEAM Skill ownership, maintenance handover and offboarding

Adding the end-to-end direction to the implementation proposal above, so the related work has one coherent target. This is the overall design brief, not a requirement to deliver every work package in one PR or an assertion that the present code already implements it. Please carry the agreed contract into OpenSpec rather than treating multiple comments as competing specifications.

A. Separate three concepts

  1. Ownership: a Skill is user-owned or namespace-owned. Namespace ownership is a real asset relationship, not a synthetic user account.
  2. Maintenance: a namespace-owned Skill may have one responsible, active member; it may temporarily have no maintainer. Namespace OWNER/ADMIN governance remains distinct from that responsibility.
  3. Attribution: original creators and version contributors remain recorded. Ownership/maintainer changes do not rewrite authorship.

Storage namespace and visibility remain unchanged by conversion. PRIVATE does not become team-readable, and namespace ownership does not make every member a maintainer. Namespace OWNER/ADMIN may govern namespace-owned Skills; an accepted maintainer may maintain/delete them subject to lifecycle and dependency checks. Former authors/maintainers have no permanent management privilege.

B. Event-to-outcome matrix

Event Intended outcome
Accepted conflicting handover Incoming Skill becomes namespace-owned; recipient becomes maintainer. Their existing PRIVATE Skill is unchanged.
Accepted non-conflicting handover Recommended uniform outcome: namespace-owned + recipient maintainer. Confirm this default in the contract before implementation.
Later handover of a namespace-owned Skill Change maintainer only; do not turn it back into personal ownership.
New TEAM membership removal Revoke the departed user's relevant internal access and maintenance rights; convert their user-owned Skills in that namespace; clear their namespace-owned maintainer assignments. No automatic replacement maintainer.
Account disabled, membership retained Authentication/account restrictions apply; no automatic ownership conversion. Namespace OWNER can use the recovery process.
Member re-added/account re-enabled Evaluate current membership, ownership and assignment. Do not automatically reclaim converted or handed-over Skills.

Voluntary handover requires an eligible owner/maintainer to initiate and the recipient to accept. An active user's personally owned Skill cannot be taken over unilaterally by a namespace manager. Recovery is limited to the original user's loss of eligibility; a reason and recipient acceptance are required, with one explicit confirmation for namespace OWNER self-recovery. Handovers of already namespace-owned work may be arranged through its authorized governance path.

Use the existing proposed request lifecycle: pending, accepted, rejected, cancelled, expired and invalidated. Default expiry is 14 days and must be enforced during actions, not just by a scheduler. Before acceptance, ownership/assignment remains unchanged; repeat/stale actions must not override a newer result. Pending transfer alone does not grant access to private package files: disclose only the information authorized for the recipient, and show the access/maintenance consequences before acceptance.

C. Same-slug records and compatibility

Different users can already leave different same-slug records. Conversion must retain each actual Skill ID and its separate content, history, visibility, statistics and dependencies. Never resolve this through forced renaming, overwrite, automatic merging or dropping an old record.

Keep user-owned uniqueness per namespace/slug/user. Namespace-owned same-slug records can coexist; distinguish them by record identity and appropriate provenance in management UI. Refactor every affected selection and mutation path to address the intended record, including subsequent uploads, reviews, download/file routes and deletion. An ID is an identifier, never authorization.

Unambiguous legacy behavior should remain usable. Where a legacy slug-only request cannot identify a unique intended target, fail safely and provide an explicit selection/update path rather than choosing the first candidate. Test Web/API/CLI end to end. Do not expand the existing allowed published/install coordinates just because maintenance or ownership changed.

D. In-flight work and concurrency

Separate handover completion from removal:

  • Handover completion must recheck active membership/account, namespace state, the request's recorded ownership/maintainer revision, current eligibility and source/global-copy consistency. For now, pending version/avatar/visibility/promotion reviews are conservative blockers; report the blocker and leave the request pending. Specify scan-only and archived/hidden cases before implementation. Serialize these checks with creation of new pending work as well as review decisions.
  • Membership removal must not wait for those tasks. Scans continue; accepted reviews are retained and must recheck current conditions. Never auto-approve or silently replace the accepted submit authority with a worker/admin identity. Invalidate stale personal handover requests and notify affected users. Where an existing review cannot safely continue, expose a manual resolution state/reason rather than silently deleting it.
  • Linked active global copies follow their source's ownership/maintenance transition consistently while retaining their existing storage namespace and provenance. They cannot be independently handed over. Global-copy governance must not accidentally grant access to private source content.
  • Coordinate actual locks/conditional updates for acceptance vs cancellation, removal/deactivation, new upload/review creation and promotion approval. Review the real mutation paths; do not assume a proposed lock order proves correctness.

E. Historical data and rollout

Access revocation and ownership reassignment are different changes.

  • Schema upgrade defaults existing rows to user ownership and retains existing owner metadata and business data. It must not mass-convert existing Skills merely because their users are currently absent from membership.
  • Once the new TEAM authorization rule is deployed, ordinary departed users cannot use old ownership/author attribution to access internal content, previews or protected files, including historical records. Public published content remains public; valid independent administrative authority is evaluated separately. Apply the same rule to browser sessions and Tokens. Explain this behavior change in release notes and user-facing messages.
  • List historical departed-owner records for authorized review; explicit remediation can convert ownership, assign maintenance or perform permitted cleanup, with real operator/reason/result records. This workflow is separate from schema startup migration. Do not backfill authorship by guessing that the current owner was the creator.
  • New removals use the new conversion flow. Failure must be observable and retryable without duplicate conversions/events; incomplete conversion must not preserve or restore departed-user access.
  • Upgrade all backends and consumers to understand namespace-owned records before enabling conversion. A nullable owner can break old binaries: old-app rollback after conversion is not presumed safe. Retain backups and verify populated-data migration/restart scenarios. Previously issued download links/caches also need an explicit revocation/expiry boundary; do not claim instant recall of already downloaded files.

F. Minimal UI and audit

Reuse existing pages/components:

  • My Skills: distinguish personal ownership vs namespace maintenance, with incoming/outgoing handover tasks.
  • Skill detail: provenance, current responsible person, handover/recovery entry and its request/history panel; distinguish same-slug records.
  • Namespace management: Skills needing a maintainer and links to authorized governance/remediation actions.
  • Member removal: affected-Skill count, immediate access impact, content retention/conversion explanation and a post-removal handling entry. No grace-period download bypass.
  • Submission/update: describe the target namespace and select the exact existing Skill for an update.
  • Notifications/old links: explain removal or handover and link to the appropriate authorized destination. Do not expose private content or suggest the Skill was deleted merely because access was removed.

Reuse existing audit infrastructure for ownership changes, maintainer assignments, removal-triggered conversion and manual historical remediation. Record actual operator/trigger, request, reason, before/after state, time and outcome. A system conversion triggered by an administrator must not be attributed to the departed user. Skill history and namespace operation history should reference the same underlying event. A whole new platform-wide audit product is unnecessary.

G. Scope and delivery

Initial scope is ordinary TEAM Skills, including PRIVATE/team-visible/public content and their linked active global copies. Exclude direct GLOBAL handover rules, personal-namespace lifecycle, system/GitHub-managed Skills, bulk/cross-namespace transfer, platform EMERGENCY takeover and multi-maintainer collaboration.

Suggested linked deliveries:

  1. TEAM access-rule correction: enforce current authorization across old and new records, with UI explanations and regressions; no ownership backfill prerequisite.
  2. Ownership/addressing prerequisite + docs(openspec): skill ownership, maintenance and handover contract #1060 workflow: add the smallest schema/domain support, exact-record compatibility, handover UI, notifications and audit. Do not enable same-slug handovers until addressing is complete.
  3. Removal conversion and historical governance: implement new-removal integration and explicit historical handling, reusing the same transition services. It may be separately delivered, but the behavior must be documented together.

The formal acceptance matrix should include normal/same-slug transfers, PRIVATE previews, post-transfer update/download/delete, stale/duplicate requests, eligibility changes, source/copy races, pending-task creation races, old clients, historical access denial, conversion retries and populated-database upgrades. Report implementation and test evidence separately from proposed behavior.

Please assess which deliveries you would like to own; we can share the remaining work. Start by consolidating the contract and flagging unresolved defaults in the existing OpenSpec. This broader brief updates earlier suggestions of a simple owner-field swap or a blanket historical ownership conversion; neither is the intended implementation.


中文总览

这次补充的是整体方法,供拆分交付及完善 OpenSpec,不要求一个 PR 一次完成全部功能。

  • **三层分开:**个人/空间归属、当前维护负责人、历史作者。空间不使用假用户身份承接技能;PRIVATE 不因转化对普通成员开放。
  • **交接冲突:**被交接技能转为空间所属,接收人成为维护负责人,原有同名 PRIVATE 内容不变。建议无冲突交接也采用统一结果,正式实施前确认。已经空间所属的技能后续只交接维护责任。
  • **精确定位:**同 slug 空间技能独立保留,更新、详情、文件、审核、删除都必须定位具体记录,不能取第一条;个人所属唯一性和原有发布坐标约束保留,旧客户端需有明确兼容路径。
  • **成员移除:**立即撤销内部访问与维护权,新移除触发空间承接并清除原负责人的维护关系;不能被扫描、审核或交接等待阻挡。停用账号本身不自动改变归属,重新加入不自动拿回已交接技能。
  • **在途任务:**扫描继续,审核保留并重新校核,不自动批准、不借后台身份补权限;旧个人交接申请失效。交接接受与扫描、各类审核、技能治理状态的具体矩阵需写清;全局副本与源一致,但不得由此开放源的私有内容。
  • **历史数据:**升级不自动批量改归属。访问按当前授权统一撤销,历史归属另行盘点、由有权限者明确处置,操作留痕。历史用户失去内部访问与历史内容被自动转交,是两个不同问题。
  • **页面与记录:**复用我的技能、详情、空间管理及通知;补交接待办、遗留技能入口、移除提示。技能历史和空间操作记录关联同一事件,不新增大套审计系统。
  • **兼容与上线:**全部后端/消费者支持新模型后再开启转化;已有数据保留;验证旧客户端、历史访问、同名更新和真实数据库并发,不能承诺新归属数据出现后直接回滚旧应用。

建议分为“访问规则修复”“归属与精确定位+#1060交接”“成员移除承接及历史治理”三个关联交付,请评估希望承接哪些部分。整体设计补齐后再进入实现,不把讨论建议冒充已实现或已验证结果。

martindissingmadsen pushed a commit to martindissingmadsen/skillhub that referenced this pull request Nov 16, 2026
… skills

Update clarify-skill-ownership-transfer with the direction agreed on
PR iflytek#1060: user or namespace ownership with one maintainer, exact-record
addressing for same-slug skills, the handover request lifecycle, and
access and conversion when a member leaves. Split into three deliveries.
Open questions with proposed defaults are listed in proposal.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CLAassistant

CLAassistant commented Nov 16, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Martin Dissing Madsen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@martindissingmadsen martindissingmadsen changed the title feat(skill): let namespace owners transfer skill ownership docs(openspec): skill ownership, maintenance and handover contract Nov 16, 2026
@martindissingmadsen

Copy link
Copy Markdown
Contributor Author

Thanks. We think this is a really good approach, and we'd like to build all three parts.

We're happy to split it into three PRs, in this order:

  1. TEAM access-rule fix
  2. Ownership model, exact-record addressing and the docs(openspec): skill ownership, maintenance and handover contract #1060 handover workflow
  3. Conversion on member removal and historical clean-up

Fair warning on PR 2: exact-record addressing touches many places that read the owner or look up a skill by slug. It will be a lot of small changes to review.

On testing: we will write the tests, including the real-database concurrency tests. We probably can't run the full validation ourselves, such as populated-database upgrades and legacy clients. We may need your help there.

OpenSpec update: this PR now contains only the updated openspec/changes/clarify-skill-ownership-transfer. It is rebased on current main. The old implementation is removed, because it doesn't fit the new model, and each delivery will start fresh from main.

  • proposal.md: summary, scope, the three deliveries and 11 open questions with proposed defaults (at the end).
  • New specs: skill-ownership-model, skill-exact-addressing, skill-handover, team-member-departure.
  • design.md and tasks.md: approach and checklist per delivery.
  • The existing Chinese text is kept unchanged below the new sections. The existing spec has one note saying which REQ-OWN requirements are partly replaced.

One point to flag: REQ-DEP-01 (departed users lose internal access) replaces the read-only exception delivered in #975 (REQ-OWN-02). We understood that from your comment, but please confirm.

Once the open questions are settled, we'll start on delivery 1.

@XiaoSeS

XiaoSeS commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

English

Thanks for updating #1060 and offering to implement all three deliveries. We have reviewed the proposed defaults. Please update the OpenSpec with the decisions below before implementation.

These are product-contract decisions, not claims that the implementation or compatibility has already been validated. The scope remains ordinary TEAM Skills, including auto-provisioned TEAM namespaces and linked active global copies. Direct GLOBAL handover, system/GitHub-managed Skills, bulk or cross-namespace transfer, platform emergency takeover and multiple maintainers remain outside this delivery.

1. Uniform handover result

Every accepted handover should produce a namespace-owned Skill with the recipient as maintainer, regardless of a same-slug conflict. A subsequent handover of a namespace-owned Skill changes only its maintainer.

Preserve the Skill ID, namespace, slug, visibility, versions, files, statistics, attribution and existing associations. The recipient's existing same-slug Skill remains unchanged.

2. Initiating handover of namespace-owned Skills

  • The current eligible maintainer may initiate voluntary handover.
  • Namespace OWNER/ADMIN may initiate governance reassignment of a namespace-owned Skill, with a reason.
  • The recipient must accept. Governance self-assignment requires one explicit confirmation and a reason.
  • These rights must not allow an OWNER/ADMIN to unilaterally take a user-owned Skill from an active member.

Keep handover browser-session-only initially; do not introduce Token-based handover permissions.

3. Scans and pending work must not create a handover deadlock

Please revise the blanket completion-blocking rule in REQ-HO-05. Handover changes maintenance responsibility; it does not publish content or approve an outstanding application. Scans and pending reviews should not automatically prevent handover completion.

Scans continue against their exact version/material, and pending applications remain recorded. Before a later decision or publication step, revalidate the current Skill, responsibility, permissions, submitted material and lifecycle conditions. Member removal must never wait for scans, reviews or handover requests.

4. Archived and hidden Skills

An archived Skill may be handed over and must remain archived. A hidden Skill should not have to be unhidden merely to arrange maintenance responsibility. Permit the eligible handover/governance path while preserving existing hidden restrictions.

Handover must not implicitly grant authority to unhide, restore, publish or promote content. Namespace governance must not acquire the platform's unhide authority through this workflow. Please explicitly define what the recipient may inspect and maintain while the Skill remains hidden.

5. Linked global copies

The active global copy follows the source Skill's effective ownership and maintenance responsibility; it must not have an independently assignable maintainer.

  • Namespace-owned source maintained by B: the copy follows that responsibility.
  • Namespace-owned source with no maintainer after removal: the copy may also have no individual maintainer.
  • A later maintainer assignment on the source applies consistently to the copy.

Prefer expressing this through the existing source association rather than maintaining two independently mutable responsibility relationships. Existing owner-dependent code still needs a coherent migration.

The copy retains its global namespace, address, provenance, publication state and governance restrictions. Public access and platform governance remain separately evaluated. Maintaining the copy must not expose PRIVATE source content or automatically unhide/publish either record.

6. Exact-record addressing and historical compatibility

We agree with optional skillId selection on existing interfaces and matching CLI support. Reuse and extend the existing resolution service.

  • Explicit IDs identify exact records but never bypass authorization. Validate the ID against the namespace and slug in the request.
  • Web links, details, versions, files, downloads and subsequent mutations retain the selected record's identity throughout the flow.
  • Update, delete, archive and handover must not subsequently resolve the target again by guessing from its slug.
  • Preserve each legacy endpoint's established, unambiguous resolution behavior. A new maintenance relationship must not silently change which historical record an old request selects.

For example, if B owns personal Skill 101 and later maintains same-slug namespace-owned Skill 202, existing personal-Skill calls must not silently switch to 202. Operations on 202 should explicitly select it.

When the target genuinely cannot be determined, require selection and expose only candidates the caller may access. Do not turn every request without skillId into a 409, or make an otherwise unambiguous public download ambiguous merely because private same-slug records exist.

Historical compatibility is a release prerequisite:

  • Do not rename, recreate or renumber historical Skills; preserve version/file associations and existing usable links.
  • Do not require every existing client to upgrade immediately.
  • Verify existing CLI installation records and subsequent update/download behavior.
  • If a proposed handover cannot safely preserve compatibility, restrict that new operation until compatibility is implemented.

Please first provide a call-site inventory distinguishing required changes from regression-only checks, plus a historical-data/legacy-client compatibility matrix. Complete addressing and compatibility validation before enabling dependent handover scenarios.

Compatibility protects users who remain legitimately authorized. The explicitly agreed loss of internal access after member removal is an authorization change, not a requirement to preserve the former owner's read exception.

7. Upload target selection

New exact-record management flows should distinguish creating a Skill from updating a particular existing Skill. If the intended update target is ambiguous, Web offers selection and CLI requires an explicit selector. Do not choose the first, most recently updated or otherwise guessed record.

Retain personal-ownership uniqueness and existing shared publication-coordinate conflict rules. Separate same-slug records do not relax publication conflicts.

8. Reviews after responsibility changes

Please revise the default that approval must always fail solely because the original submitter has left.

For a legitimately accepted application whose submitted material has not been replaced, preserve the original submitter, exact material and review history. A responsibility change removes applicable automatic-approval eligibility and leaves the application for normal human review.

An authorized reviewer may approve or reject after checking current authorization, Skill state, scan results, target visibility and all other applicable conditions. This is an explicit human governance decision, not a background worker substituting an administrator identity to supply missing submitter authority. Do not add new reviewer privileges or relax existing review restrictions.

We do not want an additional mandatory "new maintainer confirms continuation" workflow initially.

Version, avatar, visibility and promotion applications retain their respective approval requirements. Handover itself neither approves them nor expands visibility. Concurrent handover and approval must not permit decisions based on stale responsibility information.

9. Member removal and conversion

Do not require an unbounded conversion transaction before member removal can succeed.

Access revocation takes effect immediately. Conversion must be observable, idempotent and retryable; large removals may require bounded processing. Failed or incomplete conversion must not preserve or restore the departed user's internal access.

Record the removal trigger and affected records so retries cannot convert unrelated, newly created or subsequently changed Skills. Preserve source/copy consistency and send notifications after committed state changes.

Explicitly test rejoining while conversion is incomplete: rejoining must not bypass the pending conversion and silently restore the former maintenance rights. Any reassignment follows the agreed governance workflow.

10. Auto-provisioned personal namespaces

Please remove the blanket exclusion based on "personal namespace." Auto-provisioned personal namespaces are currently TEAM namespaces; their creation method must not introduce another authorization or handover exception. Apply TEAM rules consistently.

This does not add account deletion, namespace dissolution or a separate personal-asset lifecycle. Account disabling alone still does not automatically convert ownership. Existing restrictions on removing a namespace OWNER remain applicable.

11. Download-link boundary

We accept configured expiry as the boundary for already issued presigned URLs. The default is 10 minutes, but deployments may override it.

New protected requests apply current authorization. Already issued URLs may remain usable until expiry, and downloaded files cannot be recalled. Release notes and UI messages must state this accurately.

Historical records and the previous read-only exception

We explicitly confirm that REQ-DEP-01 replaces the departed-owner read-only exception delivered in #975. Departed ordinary members cannot retain internal access merely through current or historical ownership. Public published content remains public; independent administrative authority is evaluated separately.

This does not authorize automatic historical ownership conversion. Preserve historical records during upgrade and remediate ownership through explicit, authorized and audited actions.

Delivery and acceptance

  1. TEAM access-rule correction.
  2. Exact-record addressing and compatibility prerequisite, followed by ownership, maintenance and handover.
  3. New-removal conversion and explicit historical remediation.

Delivery 2 may be split into prerequisite and workflow PRs for safer review. Please update specs, scenarios and tasks, clearly mark superseded historical sections, and run the OpenSpec validator. Keep the schema upgrade non-destructive; all backends and consumers must support the new ownership model before conversion is enabled. Once namespace-owned records exist, do not presume that rolling back to older binaries is safe; define and validate the rollback boundary.

Acceptance should cover populated-data upgrades, old clients, same-slug read/update/download/delete, source/copy consistency, responsibility changes during review, conversion retries and rejoining, and real-database concurrency. We can help with populated-data upgrade and legacy-client validation. Please also ensure DCO/CLA checks pass before merging the contract PR.


中文

感谢更新 #1060,也确认你们愿意承担三个阶段的开发。我们已核对提出的默认方案,请在实现前按以下结论更新 OpenSpec。

以下是产品契约,不表示实现或兼容性已经验证通过。本期范围仍为普通 TEAM 技能,包括自动创建的 TEAM 空间及其关联活动全局副本;不扩展直接 GLOBAL 交接、系统/GitHub 托管技能、批量或跨空间交接、平台应急接管、多人维护。

1. 统一交接结果

无论有无同名冲突,交接完成后都统一为:技能属于命名空间,接收人成为维护负责人。已为空间所属的技能再次交接时,只改变负责人。

技能 ID、命名空间、slug、可见范围、版本、文件、统计、历史署名和既有关联保持不变。接收人原有同名技能不受影响。

2. 空间所属技能由谁发起交接

  • 当前有效负责人可以发起主动交接。
  • 命名空间 OWNER/ADMIN 可以对空间所属技能发起治理分配,必须填写原因。
  • 接收人接受后生效;治理分配给自己时,需要一次明确确认和原因。
  • 不能因此允许 OWNER/ADMIN 单方面拿走正常成员的个人所属技能。

首期仅允许网页登录会话交接,不新增 Token 交接权限。

3. 扫描和在途任务不能造成交接死锁

请修改 REQ-HO-05 中一律阻止交接完成的规则。交接改变维护责任,不代表发布内容或批准已有申请,扫描和待审核任务不应一律阻止交接完成。

扫描继续针对原具体版本/材料执行,已有申请保留。之后审批或发布时,重新检查当前技能、责任关系、权限、材料和生命周期条件。成员移除不能等待扫描、审核或交接任务。

4. 归档和隐藏技能

归档技能可以交接,继续保持归档。隐藏技能不应被迫先解除隐藏才能安排维护责任;允许符合条件的交接/治理处理,但保留原有隐藏限制。

交接不隐含解除隐藏、恢复、发布或提升权限,空间治理不能通过交接取得平台的解除隐藏权限。请明确新负责人在隐藏状态下可以查看和维护哪些内容。

5. 关联全局副本

活动全局副本跟随源技能的有效归属和维护责任,不单独设置可以独立变化的负责人关系。

  • 源技能为空间所属、B 负责维护,副本跟随该责任。
  • 成员移除后源技能为空间所属且无负责人,副本也可以暂时无具体负责人。
  • 后续给源指定负责人,副本一致跟随。

优先通过已有源技能关联表达这份关系,避免两边独立修改。既有依赖所有者字段的代码仍须一致迁移。

副本保留全局命名空间、地址、来源、发布状态和治理限制。公开读取与平台治理分别判断;管理副本不能获得 PRIVATE 源内容访问权,也不能顺带公开或解除任一记录的隐藏状态。

6. 精确定位与历史兼容

接受现有接口增加可选 skillId,CLI 增加对应选择能力,复用并扩展现有定位服务。

  • 指定 ID 仍须授权,并核对其与路径中的命名空间、slug 匹配。
  • Web 从列表、详情到版本、文件、下载和后续修改,始终携带同一记录身份。
  • 更新、删除、归档和交接不能在后续步骤又按 slug 猜目标。
  • 保留旧入口原有、明确且无歧义的定位语义;新增维护关系不能悄悄改变旧请求指向。

例如 B 原有个人技能 101,之后负责同名空间技能 202,原有个人技能调用不能自动切到 202;操作 202 应明确选择。

真实歧义才要求选择,候选只包含有权访问的记录。不能把所有无 skillId 请求统一改成 409,也不能仅因存在私有同名记录,让原本明确的公开下载失效。

历史兼容是上线前置条件:不改名、不重建、不重新编号历史技能;保留版本/文件关联和既有可用链接;不要求所有旧客户端立即升级;核查既有 CLI 安装记录及后续更新/下载。若某种新交接不能安全兼容,应先限制新操作,不能让历史数据承担后果。

请先提供调用点清单,区分“必须修改”和“只需回归”,并提供历史数据/旧客户端兼容矩阵。验证通过前不开放依赖它的交接场景。

兼容承诺针对仍有合法权限的用户。成员移除后失去内部访问权,是已明确的授权调整,不意味着继续保留旧所有者只读例外。

7. 上传目标选择

新精确管理流程需区分创建技能与更新具体已有技能。目标有歧义时,Web 提供选择,CLI 要求明确指定,不能默认第一条、最近更新记录或其他猜测目标。

保留个人所属唯一性和共享发布坐标冲突规则。同名记录可独立存在,不等于放宽发布冲突。

8. 负责人变化后的审核

请修改“原提交者离开后,一律禁止批准”的默认规则。

原本合法受理且材料未被替换的申请,保留原提交人、具体材料和审核历史。责任关系变化后,取消相关自动批准资格,保留任务进入正常人工审核。

有权审核者检查当前授权、技能状态、扫描、目标可见范围及其他条件后决定通过或驳回。这是明确的人工治理决定,不能由后台任务冒用管理员身份补权限;不新增审核者权限,不放宽既有审核限制。

首期不额外增加“新负责人确认继续申请”的必选流程。

版本、头像、可见范围和提升仍执行各自审批条件。交接本身不代表批准或扩大可见范围,交接与审批并发时不能使用过期责任关系作决定。

9. 成员移除与转换

不要求无上限的大事务转换全部完成,成员移除才能成功。

访问权立即撤销。转换可观察、幂等、可重试,大量技能可分批处理。转换失败或未完成,不能保留或恢复被移除用户的内部访问权。

记录具体移除事件和受影响记录,避免重试误转换无关、新建或后来已变更的技能;保持源/副本一致,状态提交后再通知。

特别验证转换未完成时重新加入:不能绕过待执行转换而自动拿回原维护权,重新分配遵守已约定的治理流程。

10. 自动创建的个人命名空间

取消按“个人空间”一概排除的规则。当前自动创建空间也是 TEAM,创建方式不应产生另一套授权或交接例外,统一适用 TEAM 规则。

不扩展账号注销、空间解散或独立个人资产生命周期。账号停用本身仍不自动改变归属,现有空间 OWNER 移除限制继续适用。

11. 下载链接边界

接受以已签发预签名 URL 的配置有效期为边界,默认 10 分钟,部署可覆盖。

新受保护请求检查当前权限;已签发链接可能在剩余有效期内可用,已下载文件无法收回。发布说明和页面提示必须准确表达。

历史记录与旧版只读例外

明确确认 REQ-DEP-01 替代 #975 的离开空间后所有者只读例外。普通成员不能仅凭当前或历史所有者身份保留内部访问;公开内容仍公开,独立管理员权限另行判断。

这不授权自动转换历史归属。升级保留历史记录,历史归属治理通过明确授权、可审计的操作处理。

交付与验收

  1. TEAM 访问规则修复。
  2. 精确定位与兼容前置改造,然后实现归属、维护和交接。
  3. 新移除转换与历史治理。

第二阶段可以拆成前置改造和交接流程两个 PR。请更新规范、场景和任务,明确标记被替代的历史条款,并运行 OpenSpec 校验。数据库升级保持非破坏性;全部后端和消费者支持新模型后再开启转换。产生空间所属记录后,不能假定可以直接回滚旧应用,必须明确并验证回滚边界。

验收覆盖存量数据升级、旧客户端、同名读取/更新/下载/删除、源副本一致性、审核期间负责人变化、转换重试及重新加入、真实数据库并发。我们可以协助存量升级和旧客户端验证。规范 PR 合并前,请确保 DCO/CLA 检查通过。

martindissingmadsen and others added 2 commits November 17, 2026 10:23
… skills

Update clarify-skill-ownership-transfer with the direction agreed on
PR iflytek#1060: user or namespace ownership with one maintainer, exact-record
addressing for same-slug skills, the handover request lifecycle, and
access and conversion when a member leaves. Split into three deliveries.
Open questions with proposed defaults are listed in proposal.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Martin Dissing Madsen <179458371+martindissingmadsen@users.noreply.github.com>
…contract

Record the 2026-11-17 maintainer rulings on the eleven open questions:
uniform namespace-owned handover result, governance initiation rules,
no blocking on scans or pending work, archived/hidden handover,
source-derived global copy responsibility, exact addressing with legacy
resolution preserved, create-vs-update upload selection, human review
after responsibility changes, bounded retryable removal conversion,
TEAM rules for auto-provisioned namespaces, and the presigned URL
expiry boundary.

Split delivery 2 into an addressing/compatibility prerequisite and the
handover workflow, define the rollback boundary, mark superseded iflytek#974
sections, and split long requirements so strict validation passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Martin Dissing Madsen <179458371+martindissingmadsen@users.noreply.github.com>
@martindissingmadsen

Copy link
Copy Markdown
Contributor Author

Thanks for the detailed decisions. The OpenSpec is updated (a8991d8):

  • All 11 decisions are written into the specs. proposal.md lists each decision and the requirement it maps to.
  • Old [Feature] 统一成员移除后的技能所有者只读权限 #974/fix(auth): keep removed skill owners read-only #975 text that no longer applies is marked as superseded. REQ-DEP-01 now replaces the read-only exception.
  • Delivery 2 is split into 2a (exact addressing and compatibility) and 2b (handover). 2a starts with the call-site inventory and the compatibility matrix you asked for.
  • design.md defines the rollback boundary: switches default to off, and older binaries are safe only while no namespace-owned Skill exists.
  • openspec validate --strict passes. DCO and CLA pass.

One case to confirm (REQ-ADDR-05): B has no personal Skill with slug x but maintains namespace-owned Skill 202 with slug x. Today an upload of x without a selector from B creates a new Skill. Updating 202 instead would change what old clients do. So we refuse the upload with a "select a Skill" error that lists 202, and create nothing. Is that right?

Once that's confirmed, we'll start on delivery 1.

@XiaoSeS

XiaoSeS commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

English

Yes, that is the intended outcome for REQ-ADDR-05. If B has no personal Skill with slug x, maintains namespace-owned Skill 202 with that slug, and uploads without a target selector, return the “select a Skill” error with 202 as an eligible update target. The request should neither update 202 nor create a new Skill. An explicit update may proceed through the existing permission and publication checks. Please include this case in the compatibility matrix for delivery 2a. You can proceed with delivery 1, the TEAM access-rule fix.

中文

确认 REQ-ADDR-05 的这个场景。B 没有个人所属的同名技能,但负责维护空间所属技能 202,上传时未指定目标,应提示「请选择技能」,并将 202 列为可选更新目标。此次请求不更新 202,也不新建技能。用户明确选择更新目标后,继续走现有权限与发布校验。请把这个场景纳入第 2a 批兼容性矩阵。第 1 批 TEAM 访问规则修复可以开始。

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants