Skip to content

Commit 642682c

Browse files
feat(web): add change-owner dialog to the skill page
Namespace owners and super admins get a "Change owner" button below the owner name on the skill page. It lists the namespace's members (minus the current owner), asks for a reason, and calls the ownership transfer endpoint. Server errors, such as the new owner already having the same slug, are shown in the dialog. The dialog controls carry skill.owner.* analytics markers and the analytics manifest is regenerated. A real-API Playwright spec covers a member not seeing the control and the namespace owner taking over the member's skill. The dialog is a self-contained component and only depends on the API added in the previous commit, so deployments with their own frontend can drop this commit and keep the endpoint. Signed-off-by: Martin Dissing-Madsen <179458371+martindissingmadsen@users.noreply.github.com>
1 parent e9c1ae5 commit 642682c

10 files changed

Lines changed: 362 additions & 75 deletions

File tree

‎docs/frontend-analytics-manifest.json‎

Lines changed: 80 additions & 75 deletions
Large diffs are not rendered by default.
Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
import { expect, test, type Page } from '@playwright/test'
2+
import { setEnglishLocale } from './helpers/auth-fixtures'
3+
import { csrfHeaders } from './helpers/csrf'
4+
import { loginWithCredentials, registerSession } from './helpers/session'
5+
import { E2eTestDataBuilder } from './helpers/test-data-builder'
6+
7+
async function currentUserId(page: Page): Promise<string> {
8+
const response = await page.context().request.get('/api/v1/auth/me')
9+
expect(response.ok()).toBeTruthy()
10+
return (await response.json()).data.userId
11+
}
12+
13+
async function skillOwnerId(page: Page, namespace: string, slug: string): Promise<string> {
14+
const response = await page.context().request.get(`/api/web/skills/${namespace}/${slug}`)
15+
expect(response.ok()).toBeTruthy()
16+
return (await response.json()).data.ownerId
17+
}
18+
19+
test.describe('Skill Owner Transfer (Real API)', () => {
20+
test.describe.configure({ timeout: 120_000 })
21+
22+
test('namespace owner takes over a member skill; the member cannot transfer', async ({ browser, page }, testInfo) => {
23+
await setEnglishLocale(page)
24+
await registerSession(page, testInfo, { allowMockSession: false })
25+
const memberId = await currentUserId(page)
26+
const memberBuilder = new E2eTestDataBuilder(page, testInfo)
27+
await memberBuilder.init()
28+
29+
const adminContext = await browser.newContext()
30+
const adminPage = await adminContext.newPage()
31+
await setEnglishLocale(adminPage)
32+
await loginWithCredentials(adminPage, {
33+
username: process.env.E2E_ADMIN_USERNAME ?? process.env.BOOTSTRAP_ADMIN_USERNAME ?? 'admin',
34+
password: process.env.E2E_ADMIN_PASSWORD ?? process.env.BOOTSTRAP_ADMIN_PASSWORD ?? 'ChangeMe!2026',
35+
}, testInfo)
36+
const adminId = await currentUserId(adminPage)
37+
const adminBuilder = new E2eTestDataBuilder(adminPage, testInfo)
38+
await adminBuilder.init()
39+
40+
let skillPath: string | undefined
41+
try {
42+
const namespace = await adminBuilder.createNamespace('e2e-owner')
43+
await adminBuilder.addNamespaceMember(namespace.slug, memberId, 'MEMBER')
44+
const skill = await memberBuilder.publishSkill(namespace.slug)
45+
await adminBuilder.approveReview(await adminBuilder.waitForPendingReview(namespace.slug, skill.slug, skill.version))
46+
skillPath = `${encodeURIComponent(skill.namespace)}/${encodeURIComponent(skill.slug)}`
47+
48+
await page.goto(`/space/${skillPath}`)
49+
await expect(page.getByRole('heading', { level: 1 }).first()).toBeVisible()
50+
await expect(page.getByRole('button', { name: 'Change owner' })).toHaveCount(0)
51+
52+
await adminPage.goto(`/space/${skillPath}`)
53+
await adminPage.getByRole('button', { name: 'Change owner' }).click()
54+
const dialog = adminPage.getByRole('dialog', { name: 'Change owner' })
55+
await dialog.getByRole('combobox', { name: 'New owner' }).click()
56+
// The namespace has two members; the current owner (the member) is not offered.
57+
await expect(adminPage.getByRole('option')).toHaveCount(1)
58+
await adminPage.getByRole('option').click()
59+
await dialog.getByLabel('Reason').fill('E2E handover')
60+
await dialog.getByRole('button', { name: 'Transfer' }).click()
61+
62+
await expect(dialog).toBeHidden()
63+
await expect.poll(() => skillOwnerId(adminPage, skill.namespace, skill.slug)).toBe(adminId)
64+
} finally {
65+
if (skillPath) {
66+
await adminPage.context().request.delete(`/api/web/skills/${skillPath}`, { headers: await csrfHeaders(adminPage) })
67+
}
68+
await memberBuilder.cleanup()
69+
await adminBuilder.cleanup()
70+
await adminContext.close()
71+
}
72+
})
73+
})

‎web/src/api/client.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1048,6 +1048,14 @@ export const skillLifecycleApi = {
10481048
body: JSON.stringify({ visibility }),
10491049
})
10501050
},
1051+
async transferOwnership(namespace: string, slug: string, newOwnerId: string, reason: string) {
1052+
const cleanNamespace = namespace.startsWith('@') ? namespace.slice(1) : namespace
1053+
return fetchJson<components['schemas']['SkillOwnerTransferResult']>(
1054+
`${WEB_API_PREFIX}/skills/${encodeURIComponent(cleanNamespace)}/${encodeURIComponent(slug)}/owner`, {
1055+
method: 'POST', headers: await ensureCsrfHeaders({ 'Content-Type': 'application/json' }),
1056+
body: JSON.stringify({ newOwnerId, reason }),
1057+
})
1058+
},
10511059
async archiveSkill(namespace: string, slug: string, reason?: string): Promise<void> {
10521060
const cleanNamespace = namespace.startsWith('@') ? namespace.slice(1) : namespace
10531061
await fetchJson<void>(`${WEB_API_PREFIX}/skills/${cleanNamespace}/${encodeURIComponent(slug)}/archive`, {
Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
/** @vitest-environment jsdom */
2+
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'
3+
import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react'
4+
import { afterEach, describe, expect, it, vi } from 'vitest'
5+
import type { ReactNode } from 'react'
6+
import { createInstance } from 'i18next'
7+
import { I18nextProvider } from 'react-i18next'
8+
import en from '@/i18n/locales/en.json'
9+
10+
const api = vi.hoisted(() => ({ listMembers: vi.fn(), transferOwnership: vi.fn() }))
11+
vi.mock('@/api/client', () => ({
12+
namespaceApi: { listMembers: api.listMembers },
13+
skillLifecycleApi: { transferOwnership: api.transferOwnership },
14+
}))
15+
vi.mock('@/shared/lib/toast', () => ({ toast: { success: vi.fn() } }))
16+
vi.mock('@/shared/ui/select', () => ({
17+
Select: ({ value, onValueChange, children, disabled }: { value: string; onValueChange: (value: string) => void; children: ReactNode; disabled?: boolean }) =>
18+
<select aria-label="New owner" value={value} onChange={(event) => onValueChange(event.target.value)} disabled={disabled}>{children}</select>,
19+
SelectTrigger: () => null,
20+
SelectValue: () => null,
21+
SelectContent: ({ children }: { children: ReactNode }) => <><option value="" />{children}</>,
22+
SelectItem: ({ value, children }: { value: string; children: ReactNode }) => <option value={value}>{children}</option>,
23+
}))
24+
import { SkillOwnerDialog } from './skill-owner-dialog'
25+
26+
async function mount() {
27+
const i18n = createInstance()
28+
await i18n.init({ lng: 'en', resources: { en: { translation: en } }, interpolation: { escapeValue: false } })
29+
const client = new QueryClient({ defaultOptions: { queries: { retry: false } } })
30+
render(<I18nextProvider i18n={i18n}><QueryClientProvider client={client}>
31+
<SkillOwnerDialog namespace="team" slug="foo" ownerId="leaver" />
32+
</QueryClientProvider></I18nextProvider>)
33+
fireEvent.click(screen.getByRole('button', { name: 'Change owner' }))
34+
}
35+
36+
describe('SkillOwnerDialog', () => {
37+
afterEach(() => { cleanup(); vi.clearAllMocks() })
38+
39+
it('offers other members only and sends the chosen owner with a trimmed reason', async () => {
40+
api.listMembers.mockResolvedValue({ items: [
41+
{ id: 1, userId: 'leaver', displayName: 'Jane Doe', role: 'MEMBER', createdAt: '' },
42+
{ id: 2, userId: 'successor', displayName: 'Sam Successor', role: 'MEMBER', createdAt: '' },
43+
], total: 2, page: 0, size: 100 })
44+
api.transferOwnership.mockResolvedValue({ ownerId: 'successor', previousOwnerId: 'leaver' })
45+
await mount()
46+
47+
await waitFor(() => expect(screen.getByRole('option', { name: 'Sam Successor' })).toBeTruthy())
48+
expect(screen.queryByRole('option', { name: 'Jane Doe' })).toBeNull()
49+
50+
const transfer = screen.getByRole('button', { name: 'Transfer' }) as HTMLButtonElement
51+
fireEvent.change(screen.getByLabelText('New owner'), { target: { value: 'successor' } })
52+
expect(transfer.disabled).toBe(true)
53+
fireEvent.change(screen.getByLabelText('Reason'), { target: { value: ' Left the company ' } })
54+
fireEvent.click(transfer)
55+
56+
await waitFor(() => expect(api.transferOwnership).toHaveBeenCalledWith('team', 'foo', 'successor', 'Left the company'))
57+
await waitFor(() => expect(screen.queryByRole('dialog')).toBeNull())
58+
})
59+
60+
it('keeps the dialog open and shows the server message when the transfer is rejected', async () => {
61+
api.listMembers.mockResolvedValue({ items: [
62+
{ id: 2, userId: 'successor', displayName: 'Sam Successor', role: 'MEMBER', createdAt: '' },
63+
], total: 1, page: 0, size: 100 })
64+
api.transferOwnership.mockRejectedValue(new Error('The new owner already has a skill named foo in this namespace.'))
65+
await mount()
66+
67+
await waitFor(() => expect(screen.getByRole('option', { name: 'Sam Successor' })).toBeTruthy())
68+
fireEvent.change(screen.getByLabelText('New owner'), { target: { value: 'successor' } })
69+
fireEvent.change(screen.getByLabelText('Reason'), { target: { value: 'Handover' } })
70+
fireEvent.click(screen.getByRole('button', { name: 'Transfer' }))
71+
72+
await waitFor(() => expect(screen.getByRole('alert').textContent).toContain('already has a skill named foo'))
73+
expect(screen.getByRole('dialog')).toBeTruthy()
74+
})
75+
})
Lines changed: 78 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
1+
import { useState } from 'react'
2+
import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query'
3+
import { useTranslation } from 'react-i18next'
4+
import { namespaceApi, skillLifecycleApi } from '@/api/client'
5+
import { Button } from '@/shared/ui/button'
6+
import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogHeader, DialogTitle } from '@/shared/ui/dialog'
7+
import { Label } from '@/shared/ui/label'
8+
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/shared/ui/select'
9+
import { Textarea } from '@/shared/ui/textarea'
10+
import { toast } from '@/shared/lib/toast'
11+
12+
// One page is enough for typical teams; namespaces past this size need a member search here.
13+
const MEMBER_PAGE_SIZE = 100
14+
15+
/** Lets a namespace owner or super admin hand a skill to another member of its namespace. */
16+
export function SkillOwnerDialog({ namespace, slug, ownerId }: { namespace: string; slug: string; ownerId?: string }) {
17+
const { t } = useTranslation()
18+
const queryClient = useQueryClient()
19+
const [open, setOpen] = useState(false)
20+
const [newOwnerId, setNewOwnerId] = useState('')
21+
const [reason, setReason] = useState('')
22+
const [error, setError] = useState('')
23+
const members = useQuery({
24+
queryKey: ['namespaces', namespace, 'members', { page: 0, size: MEMBER_PAGE_SIZE }],
25+
queryFn: () => namespaceApi.listMembers(namespace, { page: 0, size: MEMBER_PAGE_SIZE }),
26+
enabled: open,
27+
})
28+
const candidates = (members.data?.items ?? []).filter(member => member.userId !== ownerId)
29+
const mutation = useMutation({
30+
mutationFn: () => skillLifecycleApi.transferOwnership(namespace, slug, newOwnerId, reason.trim()),
31+
onSuccess: async () => {
32+
toast.success(t('skillOwner.saved'))
33+
setOpen(false)
34+
await Promise.all([
35+
queryClient.invalidateQueries({ queryKey: ['skills'] }),
36+
queryClient.invalidateQueries({ queryKey: ['skill'] }),
37+
queryClient.invalidateQueries({ queryKey: ['my-skills'] }),
38+
])
39+
},
40+
onError: (cause) => setError(cause.message),
41+
})
42+
return <>
43+
<Button data-analytics-id="skill.owner.open" size="sm" variant="outline" onClick={() => {
44+
setNewOwnerId('')
45+
setReason('')
46+
setError('')
47+
setOpen(true)
48+
}}>{t('skillOwner.title')}</Button>
49+
<Dialog open={open} onOpenChange={(value) => { if (!mutation.isPending) setOpen(value) }}>
50+
<DialogContent>
51+
<DialogHeader>
52+
<DialogTitle>{t('skillOwner.title')}</DialogTitle>
53+
<DialogDescription>{t('skillOwner.description')}</DialogDescription>
54+
</DialogHeader>
55+
{members.isError && <p role="alert" className="text-sm text-destructive">{t('skillOwner.membersFailed')}</p>}
56+
<div className="space-y-2">
57+
<Label htmlFor="skill-new-owner">{t('skillOwner.newOwner')}</Label>
58+
<Select value={newOwnerId} onValueChange={setNewOwnerId} disabled={mutation.isPending || !members.isSuccess}>
59+
<SelectTrigger data-analytics-id="skill.owner.interact" id="skill-new-owner"><SelectValue placeholder={t('skillOwner.selectPlaceholder')} /></SelectTrigger>
60+
<SelectContent>{candidates.map(member =>
61+
<SelectItem data-analytics-id="skill.owner.select" key={member.userId} value={member.userId}>{member.displayName || member.userId}</SelectItem>)}
62+
</SelectContent>
63+
</Select>
64+
</div>
65+
<div className="space-y-2">
66+
<Label htmlFor="skill-owner-reason">{t('skillOwner.reason')}</Label>
67+
<Textarea id="skill-owner-reason" value={reason} maxLength={500} disabled={mutation.isPending}
68+
placeholder={t('skillOwner.reasonPlaceholder')} onChange={(event) => setReason(event.target.value)} />
69+
</div>
70+
{error && <p role="alert" className="text-sm text-destructive">{error}</p>}
71+
<DialogFooter>
72+
<Button data-analytics-id="skill.owner.cancel" variant="outline" disabled={mutation.isPending} onClick={() => setOpen(false)}>{t('dialog.cancel')}</Button>
73+
<Button data-analytics-id="skill.owner.confirm" disabled={mutation.isPending || !newOwnerId || !reason.trim()} onClick={() => mutation.mutate()}>{t('skillOwner.submit')}</Button>
74+
</DialogFooter>
75+
</DialogContent>
76+
</Dialog>
77+
</>
78+
}

‎web/src/i18n/locales/en.json‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3229,6 +3229,17 @@
32293229
"restoreHint": "Restore the archived space.",
32303230
"deleteHint": "Permanently delete the space. Handle its skills and members first."
32313231
},
3232+
"skillOwner": {
3233+
"title": "Change owner",
3234+
"description": "Hand this skill to another namespace member. Its address, versions, and statistics stay the same.",
3235+
"newOwner": "New owner",
3236+
"selectPlaceholder": "Select a member",
3237+
"membersFailed": "Couldn't load namespace members.",
3238+
"reason": "Reason",
3239+
"reasonPlaceholder": "The previous owner left the organization",
3240+
"submit": "Transfer",
3241+
"saved": "Owner changed"
3242+
},
32323243
"skillVisibility": {
32333244
"pendingList": "Requested {{visibility}} · review pending. Current access remains in effect.",
32343245
"title": "Visibility",

‎web/src/i18n/locales/ko.json‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3510,6 +3510,17 @@
35103510
"restoreHint": "보관된 공간을 복원합니다.",
35113511
"deleteHint": "공간을 영구 삭제합니다. 먼저 스킬과 멤버를 처리하세요."
35123512
},
3513+
"skillOwner": {
3514+
"title": "소유자 변경",
3515+
"description": "이 스킬을 네임스페이스의 다른 멤버에게 넘깁니다. 주소, 버전, 통계는 그대로 유지됩니다.",
3516+
"newOwner": "새 소유자",
3517+
"selectPlaceholder": "멤버 선택",
3518+
"membersFailed": "네임스페이스 멤버를 불러오지 못했습니다.",
3519+
"reason": "사유",
3520+
"reasonPlaceholder": "이전 소유자가 조직을 떠났습니다",
3521+
"submit": "이전",
3522+
"saved": "소유자가 변경되었습니다"
3523+
},
35133524
"skillVisibility": {
35143525
"pendingList": "요청한 공개 범위: {{visibility}} · 검토 대기 중. 현재 접근 범위는 유지됩니다.",
35153526
"title": "공개 범위",

‎web/src/i18n/locales/ru.json‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3231,6 +3231,17 @@
32313231
"restoreHint": "Восстановить архивированное пространство.",
32323232
"deleteHint": "Удалить пространство навсегда. Сначала обработайте его навыки и участников."
32333233
},
3234+
"skillOwner": {
3235+
"title": "Сменить владельца",
3236+
"description": "Передайте скилл другому участнику пространства имён. Адрес, версии и статистика не изменятся.",
3237+
"newOwner": "Новый владелец",
3238+
"selectPlaceholder": "Выберите участника",
3239+
"membersFailed": "Не удалось загрузить участников пространства имён.",
3240+
"reason": "Причина",
3241+
"reasonPlaceholder": "Прежний владелец покинул организацию",
3242+
"submit": "Передать",
3243+
"saved": "Владелец изменён"
3244+
},
32343245
"skillVisibility": {
32353246
"pendingList": "Запрошено: {{visibility}} · на рассмотрении. Текущий доступ сохраняется.",
32363247
"title": "Видимость",

‎web/src/i18n/locales/zh.json‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3228,6 +3228,17 @@
32283228
"restoreHint": "恢复已归档空间。",
32293229
"deleteHint": "永久删除空间,请先处理其中的技能和成员。"
32303230
},
3231+
"skillOwner": {
3232+
"title": "更改所有者",
3233+
"description": "将该技能交给本空间的其他成员维护。地址、版本和统计数据保持不变。",
3234+
"newOwner": "新所有者",
3235+
"selectPlaceholder": "选择成员",
3236+
"membersFailed": "无法加载空间成员。",
3237+
"reason": "原因",
3238+
"reasonPlaceholder": "原所有者已离开组织",
3239+
"submit": "转移",
3240+
"saved": "所有者已更改"
3241+
},
32313242
"skillVisibility": {
32323243
"pendingList": "申请{{visibility}} · 审核中,批准前保持当前范围。",
32333244
"title": "可见范围",

‎web/src/pages/skill-detail.tsx‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { useMutation, useQueryClient } from '@tanstack/react-query'
55
import { ArrowLeft, ArrowUpCircle, Boxes, ChevronDown, ChevronUp, Clock, Folder, Globe, Lock, RefreshCw, ShieldCheck, Terminal, User, Users } from 'lucide-react'
66
import { MarkdownRenderer } from '@/features/skill/markdown-renderer'
77
import { SkillVisibilityDialog } from '@/features/skill/skill-visibility-dialog'
8+
import { SkillOwnerDialog } from '@/features/skill/skill-owner-dialog'
89
import { SkillAvatar } from '@/features/skill/skill-avatar'
910
import { SkillAvatarTakedown } from '@/features/skill/skill-avatar-takedown'
1011
import { resolvePackageRelativeLink } from '@/features/skill/package-relative-link'
@@ -241,6 +242,8 @@ export function SkillDetailPage() {
241242
const canInteract = skill?.canInteract ?? true
242243
const canReport = skill?.canReport ?? true
243244
const canHardDeleteSkill = Boolean(skill && user && ((!skill.ownerReadOnly && skill.ownerId === user.userId) || hasRole('SUPER_ADMIN')))
245+
const canTransferOwner = Boolean(skill && user && (hasRole('SUPER_ADMIN')
246+
|| myNamespaces?.some((item) => item.slug === namespace && item.currentUserRole === 'OWNER')))
244247
const canManageLabels = Boolean(skill && user && (skill.canManageLifecycle || hasRole('SUPER_ADMIN')))
245248
const canManageSecurityScan = Boolean(skill && user && (
246249
skill.canManageLifecycle || hasRole('SKILL_ADMIN') || hasRole('SUPER_ADMIN')
@@ -936,6 +939,7 @@ export function SkillDetailPage() {
936939
</div>
937940
</div>
938941
)}
942+
{canTransferOwner && <div><SkillOwnerDialog namespace={namespace} slug={slug} ownerId={skill.ownerId} /></div>}
939943
{selectedSummary && (
940944
<p className="text-lg text-muted-foreground leading-relaxed">{selectedSummary}</p>
941945
)}

0 commit comments

Comments
 (0)