Skip to content

fix(degreeworks): duplicate courses#334

Merged
laggycomputer merged 2 commits intomainfrom
fix-duplicated-course-lists
Mar 18, 2026
Merged

fix(degreeworks): duplicate courses#334
laggycomputer merged 2 commits intomainfrom
fix-duplicated-course-lists

Conversation

@HwijungK
Copy link
Collaborator

Description

back in #286 when the logic was changed in AuditParser.ts to filter out courses that didn't meet a minimum unit requirement, the map toInclude, which mapped course ids to course objects, was turned to type [string, course][].

Degreeworks requirements can return duplicate courses in a requirement, for example:

Information and Computer Science Minor (459) has a requirement, "2 upper-div courses from list" with a course list that contains both COMPSCI 111-144 and COMPSCI 122@, which when normalized, would result in duplicate courses. Not having ToInclude be a map meant courses were added multiple times.

Simply turning the variable back into a map solves the duplicate course issue.

Related Issue

#324

How Has This Been Tested?

iterated through requirements across all majors and minors and searched for duplicate course

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code involves a change to the database schema.
  • My code requires a change to the documentation.

@HwijungK HwijungK temporarily deployed to staging-334 March 10, 2026 03:46 — with GitHub Actions Inactive
@HwijungK HwijungK marked this pull request as ready for review March 10, 2026 03:58
@HwijungK HwijungK requested a review from laggycomputer March 10, 2026 03:58
@laggycomputer laggycomputer linked an issue Mar 10, 2026 that may be closed by this pull request
Copy link
Member

@laggycomputer laggycomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, no notes. Do you remember why you changed this away from a map in the previous PR?

@laggycomputer laggycomputer changed the title fix (DegreeWorks): duplicate courses fix(degreeworks): duplicate courses Mar 10, 2026
@HwijungK HwijungK temporarily deployed to staging-334 March 16, 2026 18:22 — with GitHub Actions Inactive
@laggycomputer laggycomputer merged commit 935aeae into main Mar 18, 2026
1 check passed
@laggycomputer laggycomputer deleted the fix-duplicated-course-lists branch March 18, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DegreeWorks: duplicated courses in requirements

2 participants