fix(degreeworks): duplicate courses#334
Merged
laggycomputer merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
laggycomputer
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
back in #286 when the logic was changed in
AuditParser.tsto filter out courses that didn't meet a minimum unit requirement, the maptoInclude, which mapped course ids to course objects, was turned to type [string, course][].Degreeworks requirements can return duplicate courses in a requirement, for example:
Information and Computer Science Minor (459) has a requirement, "2 upper-div courses from list" with a course list that contains both COMPSCI 111-144 and COMPSCI 122@, which when normalized, would result in duplicate courses. Not having
ToIncludebe a map meant courses were added multiple times.Simply turning the variable back into a map solves the duplicate course issue.
Related Issue
#324
How Has This Been Tested?
iterated through requirements across all majors and minors and searched for duplicate course
Types of changes
Checklist: