Skip to content

IBX-10653: flatpickr doesn't save seconds (unless minutes or other elements are changed afterwards) #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 4.6
Choose a base branch
from
+16 −7
Open

IBX-10653: flatpickr doesn't save seconds (unless minutes or other elements are changed afterwards) #1747

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b9f002
IBX-10653: flatpickr doesn't save seconds (unless minutes or other el…
vidarl Oct 17, 2025
2dc1153
Apply suggestions from code review
vidarl Nov 5, 2025
4b276ea
fixup! Apply suggestions from code review
vidarl Nov 5, 2025
f818f66
fixup! IBX-10653: flatpickr doesn't save seconds (unless minutes or o…
vidarl Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/bundle/Resources/public/js/scripts/core/date.time.picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class DateTimePicker {
}
}

onKeyUp(isMinute, event) {
onKeyUp(type, event) {
const inputValue = event.target.value;

if (inputValue.length === 0) {
Expand All @@ -120,10 +120,16 @@ class DateTimePicker {
return;
}

if (isMinute) {
flatpickrDate.setMinutes(value);
} else {
flatpickrDate.setHours(value);
switch (type) {
case 'hours':
flatpickrDate.setHours(value);
break;
case 'minutes':
flatpickrDate.setMinutes(value);
break;
case 'seconds':
flatpickrDate.setSeconds(value);
break;
}

if (this.flatpickrInstance.config.minDate?.getTime() > flatpickrDate.getTime()) {
Expand All @@ -150,8 +156,11 @@ class DateTimePicker {
);

if (this.flatpickrInstance.config.enableTime) {
this.flatpickrInstance.minuteElement.addEventListener('keyup', this.onKeyUp.bind(this, true), false);
this.flatpickrInstance.hourElement.addEventListener('keyup', this.onKeyUp.bind(this, false), false);
this.flatpickrInstance.hourElement.addEventListener('keyup', this.onKeyUp.bind(this, 'hours'), false);
this.flatpickrInstance.minuteElement.addEventListener('keyup', this.onKeyUp.bind(this, 'minutes'), false);
if (this.flatpickrInstance.secondElement !== undefined) {
Copy link
Contributor Author

@vidarl vidarl Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI : I also had to add this check as the existences of the secondElement is dependent on config: https://github.com/ibexa/admin-ui-assets/blob/v4.6.25/src/bundle/Resources/public/vendors/flatpickr/dist/esm/index.js#L722-L725

this.flatpickrInstance.secondElement.addEventListener('keyup', this.onKeyUp.bind(this, 'seconds'), false);
}
}
}
}
Expand Down
Loading