IBX-10653: flatpickr doesn't save seconds (unless minutes or other elements are changed afterwards)

[vidarl]

🎫 Issue	IBX-10653

Description:

Event listener for second element missing, causing seconds not to be saved in the picker

For QA:

Documentation:

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[GrabowskiM]

as only one of these is used in single call, it can be made into single variable

Suggested change

	onKeyUp(isHour, isMinute, isSecond, event) {
	onKeyUp(type, event) {

[GrabowskiM]

and with changing to single variable this can be remade

Suggested change

	if (isHour) {
	flatpickrDate.setHours(value);
	} else if (isMinute) {
	flatpickrDate.setMinutes(value);
	} else if (isSecond) {
	flatpickrDate.setSeconds(value);
	switch (type) {
	case 'hours':
	flatpickrDate.setHours(value);
	break;
	case 'minutes':
	flatpickrDate.setMinutes(value);
	break;
	case 'seconds':
	flatpickrDate.setSeconds(value);
	break;
	}

or ifs if someone doesn't like switches ;)

[GrabowskiM]

and than here as well:

Suggested change

	this.flatpickrInstance.hourElement.addEventListener('keyup', this.onKeyUp.bind(this, true, false, false), false);
	this.flatpickrInstance.minuteElement.addEventListener('keyup', this.onKeyUp.bind(this, false, true, false), false);
	this.flatpickrInstance.secondElement.addEventListener('keyup', this.onKeyUp.bind(this, false, false, true), false);
	this.flatpickrInstance.hourElement.addEventListener('keyup', this.onKeyUp.bind(this, 'hours'), false);
	this.flatpickrInstance.minuteElement.addEventListener('keyup', this.onKeyUp.bind(this, 'minutes'), false);
	this.flatpickrInstance.secondElement.addEventListener('keyup', this.onKeyUp.bind(this, 'seconds'), false);