Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --width --height type parsing on opencv and intelrealsense scripts #556

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

apockill
Copy link

@apockill apockill commented Dec 7, 2024

Super minor PR. I had to set --width and --height on the opencv script when testing things out, and found that it wasn't working since it was trying to give cv2 caps a string.

@Cadene Cadene enabled auto-merge (squash) December 8, 2024 23:30
@Cadene
Copy link
Collaborator

Cadene commented Dec 8, 2024

Thanks!

@Cadene Cadene disabled auto-merge December 8, 2024 23:32
@Cadene
Copy link
Collaborator

Cadene commented Dec 8, 2024

If you have time, could update intelrealsense.py as well?

parser.add_argument(
"--width",
type=str,
default=640,
help="Set the width for all cameras. If not provided, use the default width of each camera.",
)
parser.add_argument(
"--height",
type=str,
default=480,
help="Set the height for all cameras. If not provided, use the default height of each camera.",
)

@eDeveloperOZ
Copy link

There you go @Cadene #562

@apockill apockill changed the title Fix --width --height type parsing on opencv script Fix --width --height type parsing on opencv and intelrealsense scripts Dec 9, 2024
@apockill
Copy link
Author

apockill commented Dec 9, 2024

If you have time, could update intelrealsense.py as well?

parser.add_argument(
"--width",
type=str,
default=640,
help="Set the width for all cameras. If not provided, use the default width of each camera.",
)
parser.add_argument(
"--height",
type=str,
default=480,
help="Set the height for all cameras. If not provided, use the default height of each camera.",
)

No problem- pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants