-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More CI cleanup, add style workflow #107
Conversation
764b98f
to
e424707
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So cool, thank you Simon for converging on a perfect infra workflow ;)
A thought: I am wondering how we could track metrics regarding infra workflow, for instance: install time
Thanks! I will look into it (this looks appealing 👀). Off the top of my head, it seems that test run times have significantly increased lately and looking at the durations mentioned above, it looks like this is due to the tests added/changed for the examples and datasets. We should maybe review those as well in a future PR to make them faster. |
- Changes on the `test.yml` workflow: - Using poetry instead of pip. Contrary to what I wrote in huggingface#75, it is possible to use poetry (and have the benefits of shorter install times) without the need for having two separate versions of `pyproject.toml` and `poetry.lock`. - Reduce the trigger scope to only run when files in these directories are modified: - `lerobot/` - `tests/` - `examples/` - `.github/` - Add `style.yml` workflow for doing a `ruff check` pass on the code - More cleanup (removed deprecated workflow)
This does:
test.yml
workflow:pyproject.toml
andpoetry.lock
.lerobot/
tests/
examples/
.github/
style.yml
workflow for doing aruff check
pass on the code