Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI cleanup, add style workflow #107

Merged
merged 31 commits into from
Apr 27, 2024

Conversation

aliberts
Copy link
Collaborator

@aliberts aliberts commented Apr 26, 2024

This does:

  • Changes on the test.yml workflow:
    • Using poetry instead of pip. Contrary to what I wrote in CI nightlies cpu/gpu & cleanup #75, it is possible to use poetry (and have the benefits of shorter install times) without the need for having two separate versions of pyproject.toml and poetry.lock.
    • Reduce the trigger scope to only run when files in these directories are modified:
      • lerobot/
      • tests/
      • examples/
      • .github/
  • Add style.yml workflow for doing a ruff check pass on the code
  • More cleanup (removed deprecated workflow)

@aliberts aliberts added tests Problems with test coverage, failures, or improvements to testing CI ssues related to the continuous integration pipeline labels Apr 26, 2024
@aliberts aliberts self-assigned this Apr 26, 2024
@aliberts aliberts changed the title Add Style workflow Add Style workflow, remove deprecated CI Apr 26, 2024
@aliberts aliberts force-pushed the user/aliberts/2024_04_25_style_workflow branch from 764b98f to e424707 Compare April 27, 2024 06:49
@aliberts aliberts changed the title Add Style workflow, remove deprecated CI More CI cleanup, add style workflow Apr 27, 2024
@aliberts aliberts marked this pull request as ready for review April 27, 2024 07:05
@aliberts aliberts requested a review from Cadene April 27, 2024 07:07
Copy link
Collaborator

@Cadene Cadene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool, thank you Simon for converging on a perfect infra workflow ;)

A thought: I am wondering how we could track metrics regarding infra workflow, for instance: install time

@aliberts
Copy link
Collaborator Author

So cool, thank you Simon for converging on a perfect infra workflow ;)

A thought: I am wondering how we could track metrics regarding infra workflow, for instance: install time

Thanks! I will look into it (this looks appealing 👀).
In the meantime, I've just added durations to be printed in test (in 3cc93ab, you can view the result here )

Off the top of my head, it seems that test run times have significantly increased lately and looking at the durations mentioned above, it looks like this is due to the tests added/changed for the examples and datasets. We should maybe review those as well in a future PR to make them faster.

@aliberts aliberts merged commit fdf6a0c into main Apr 27, 2024
2 checks passed
@aliberts aliberts deleted the user/aliberts/2024_04_25_style_workflow branch April 27, 2024 07:37
menhguin pushed a commit to menhguin/lerobot that referenced this pull request Feb 9, 2025
- Changes on the `test.yml` workflow:
  - Using poetry instead of pip. Contrary to what I wrote in huggingface#75, it is possible to use poetry (and have the benefits of shorter install times) without the need for having two separate versions of `pyproject.toml` and `poetry.lock`.
  - Reduce the trigger scope to only run when files in these directories are modified:
    - `lerobot/`
    - `tests/`
    - `examples/`
    - `.github/`
- Add `style.yml` workflow for doing a `ruff check` pass on the code
- More cleanup (removed deprecated workflow)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI ssues related to the continuous integration pipeline tests Problems with test coverage, failures, or improvements to testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants