Add Simplified Chinese (zh-CN) localization - #61
Conversation
|
@zeemohhh7788-maker is attempting to deploy a commit to the Krystian's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi! I’d like to contribute Simplified Chinese ( I noticed the README asks contributors to open an issue before adding a new language, but issue creation is currently restricted, so I’m using this Draft PR to confirm the language code and contribution with you first. The translation and integration have been completed and locally validated, including locale consistency checks and the frontend production build. If Thanks! |
|
Hi, thanks for the contribution! zh-CN is the correct locale code for Simplified Chinese, and I’m not aware of anyone else currently working on this translation. Opening a draft PR was perfectly fine. Before marking the PR as ready, please fix the system locale detection. The current implementation removes the region/script before checking the locale, so zh-TW, zh-HK, and zh-Hant would also be mapped to Simplified Chinese. Please map only Simplified Chinese variants such as zh-CN, zh-SG, and zh-Hans to zh-CN. Unsupported Traditional Chinese locales should fall back to English for now. Please also confirm that both commands pass: After that, feel free to mark the PR as ready for review. Thanks again! |
|
Thanks for the review! I updated the system locale detection so only Simplified Chinese variants ( I also added regression tests for both Simplified and Traditional Chinese locale variants. Validation completed on Windows CI:
CI evidence: https://github.com/zeemohhh7788-maker/mouzi-zh-cn-ci-20260827/actions/runs/33073845091 The full installer bundle was not signed in the Fork because the official updater private key is intentionally unavailable there; the unsigned Tauri application build passed. I’m marking the PR ready for review now. Thanks again! |
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Summary
Adds Simplified Chinese (
zh-CN) localization to Mouzi.Changes
zh-CNfrontend locale;zh-CNin i18next and the language selector;zh-CN;Validation
zh-CN.jsonmatches all 142 leaf keys inen.json;git diff --checkpasses;Note
The repository currently restricts new Issue creation for this account, so I could not open the requested language-confirmation issue first. Please confirm that
zh-CNis the preferred language code and that there is no duplicate translation effort.This pull request is intentionally opened as a draft. Rust/Tauri compilation for the current v0.1.6 baseline should be confirmed by project CI before it is marked ready for review. The earlier v0.1.5 Windows build passed.
Summary by cubic
Adds Simplified Chinese (
zh-CN) localization across the frontend, tray, and system notifications.zh-CNlocale is registered in i18next and the language selector; system locale detection maps Simplified Chinese variants (zh-CN,zh-SG,zh-Hans) tozh-CNand falls back to English for Traditional or ambiguous ones (zh-TW,zh-HK,zh-Hant,zh).Written for commit dd1e925. Summary will update on new commits.